Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287433: [PPC64] g1_write_barrier_pre needs extension for Loom #8918

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 27, 2022

Loom uses c2i_entry_barrier which needs to preserve more registers than currently implemented in g1_write_barrier_pre. See JBS for details.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287433: [PPC64] g1_write_barrier_pre needs extension for Loom

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8918/head:pull/8918
$ git checkout pull/8918

Update a local copy of the PR:
$ git checkout pull/8918
$ git pull https://git.openjdk.java.net/jdk pull/8918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8918

View PR using the GUI difftool:
$ git pr show -t 8918

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8918.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 27, 2022
@openjdk
Copy link

openjdk bot commented May 27, 2022

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label May 27, 2022
@mlbridge
Copy link

mlbridge bot commented May 27, 2022

Webrevs

Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Martin,

this looks good, thanks!
I've applied the change on the ppc loom port (WIP). My BasicExp tests work now with g1.

Cheers, Richard.

@openjdk
Copy link

openjdk bot commented May 30, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287433: [PPC64] g1_write_barrier_pre needs extension for Loom

Reviewed-by: rrich, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • d833173: 8286711: AArch64: serviceability agent tests fail with PAC enabled
  • 19fb8ab: 8287195: AArch64: Client VM build failure after JDK-8283689
  • 1b9987c: 8287288: Fix some typos in C1
  • 447ae00: 8287418: riscv: Fix correctness issue of MacroAssembler::movptr
  • a27ba1a: 8287363: null pointer should use NULL instead of 0
  • 744b822: 8287073: NPE from CgroupV2Subsystem.getInstance()
  • 5848a60: 8286093: java/awt/geom/Path2D/UnitTest.java failed with "RuntimeException: 2D bounds too small"
  • 3d2d039: 8287440: Typo in package-info.java of java.util.random
  • 36350bf: 8287484: JFR: Seal RecordedObject
  • a6e2e22: 8285008: JFR: jdk/jfr/jmx/streaming/TestClose.java failed with "Exception: Expected repository to be empty"
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/22e2067349fc8a82bea214a30f5e975bbebcb44b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 30, 2022
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to my non-ppcish eyes.

@TheRealMDoerr
Copy link
Contributor Author

Thank you for testing and for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2022

Going to push as commit eb8d067.
Since your change was applied there have been 21 commits pushed to the master branch:

  • d833173: 8286711: AArch64: serviceability agent tests fail with PAC enabled
  • 19fb8ab: 8287195: AArch64: Client VM build failure after JDK-8283689
  • 1b9987c: 8287288: Fix some typos in C1
  • 447ae00: 8287418: riscv: Fix correctness issue of MacroAssembler::movptr
  • a27ba1a: 8287363: null pointer should use NULL instead of 0
  • 744b822: 8287073: NPE from CgroupV2Subsystem.getInstance()
  • 5848a60: 8286093: java/awt/geom/Path2D/UnitTest.java failed with "RuntimeException: 2D bounds too small"
  • 3d2d039: 8287440: Typo in package-info.java of java.util.random
  • 36350bf: 8287484: JFR: Seal RecordedObject
  • a6e2e22: 8285008: JFR: jdk/jfr/jmx/streaming/TestClose.java failed with "Exception: Expected repository to be empty"
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/22e2067349fc8a82bea214a30f5e975bbebcb44b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2022
@openjdk openjdk bot closed this May 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2022
@openjdk
Copy link

openjdk bot commented May 30, 2022

@TheRealMDoerr Pushed as commit eb8d067.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8287433_PPC64_g1BarrierRegPreserve branch May 30, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants