Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287437: Temporarily disable Continuations::enabled() for platforms which don't have an implementation, yet #8919

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 27, 2022

Hello,

I'd like to disable Continuations::enabled() for platforms, which don't support Loom, yet. This enables working on Panama which is also controlled by --enable-preview.

I'm proposing this for all platforms which have an unresolved porting issue here:
JDK-8284161

Please review and provide feedback if this makes sense for your platform.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287437: Temporarily disable Continuations::enabled() for platforms which don't have an implementation, yet

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8919/head:pull/8919
$ git checkout pull/8919

Update a local copy of the PR:
$ git checkout pull/8919
$ git pull https://git.openjdk.java.net/jdk pull/8919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8919

View PR using the GUI difftool:
$ git pr show -t 8919

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8919.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 27, 2022
@openjdk
Copy link

openjdk bot commented May 27, 2022

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label May 27, 2022
@mlbridge
Copy link

mlbridge bot commented May 27, 2022

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

That is actually a much better idea than chasing problemlists for x86_32!
I'd probably just define the platforms where Loom is implemented: AMD64 and AARCH64.

@AlanBateman
Copy link
Contributor

AlanBateman commented May 27, 2022

I'd probably just define the platforms where Loom is implemented: AMD64 and AARCH64.

I think that would be better too.

I hope to propose changes soon that adds an alternative virtual thread implementation that is backed by a platform thread (1-1 mapping). This clearly won't scale but it should be enough to pass conformance tests on platforms that might not have VM support for continuations for some time. Part of that needs to separate "supported by VM" from "preview features are enabled" as it has to be surfaced to the library code so it can choose the implementation.

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented May 27, 2022

I'd probably just define the platforms where Loom is implemented: AMD64 and AARCH64.

I think that would be better too.

Thanks for the feedback! I've changed it.

I hope to propose changes soon that adds an alternative virtual thread implementation that is backed by a platform thread (1-1 mapping). This clearly won't scale but it should be enough to pass conformance tests on platforms that might not have VM support for continuations for some time. Part of that needs to separate "supported by VM" from "preview features are enabled" as it has to be surfaced to the library code so it can choose the implementation.

That sounds great!

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine to me. I tested x86_64 and AArch64 with jdk_loom hotspot_loom, and they pass.

@openjdk
Copy link

openjdk bot commented May 27, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287437: Temporarily disable Continuations::enabled() for platforms which don't have an implementation, yet

Reviewed-by: shade, alanb, rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • d833173: 8286711: AArch64: serviceability agent tests fail with PAC enabled
  • 19fb8ab: 8287195: AArch64: Client VM build failure after JDK-8283689
  • 1b9987c: 8287288: Fix some typos in C1
  • 447ae00: 8287418: riscv: Fix correctness issue of MacroAssembler::movptr
  • a27ba1a: 8287363: null pointer should use NULL instead of 0
  • 744b822: 8287073: NPE from CgroupV2Subsystem.getInstance()
  • 5848a60: 8286093: java/awt/geom/Path2D/UnitTest.java failed with "RuntimeException: 2D bounds too small"
  • 3d2d039: 8287440: Typo in package-info.java of java.util.random
  • 36350bf: 8287484: JFR: Seal RecordedObject
  • a6e2e22: 8285008: JFR: jdk/jfr/jmx/streaming/TestClose.java failed with "Exception: Expected repository to be empty"
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/777f813e9b2688034d77523b4142dd67e1d9f38b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 27, 2022
@theRealAph
Copy link
Contributor

theRealAph commented May 27, 2022

I hope to propose changes soon that adds an alternative virtual thread implementation that is backed by a platform thread (1-1 mapping). This clearly won't scale but it should be enough to pass conformance tests on platforms that might not have VM support for continuations for some time. Part of that needs to separate "supported by VM" from "preview features are enabled" as it has to be surfaced to the library code so it can choose the implementation.

That's excellent news. Thank you.

@AlanBateman
Copy link
Contributor

AlanBateman commented May 29, 2022

That's excellent news. Thank you.

I've created PR 8939 and hope to have it ready for review in a few days.

Copy link
Contributor

@reinrich reinrich left a comment

Hi Martin,

the change looks good to me.

Thanks, Richard.

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented May 30, 2022

Thanks for the reviews! And thanks for working on #8939 which is an interesting approach.
/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2022

Going to push as commit b1b9674.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 30, 2022
@openjdk openjdk bot closed this May 30, 2022
@openjdk openjdk bot removed ready rfr labels May 30, 2022
@openjdk
Copy link

openjdk bot commented May 30, 2022

@TheRealMDoerr Pushed as commit b1b9674.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8287437_disableContinuations branch May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
5 participants