Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287463: JFR: Disable TestDevNull.java on Windows #8929

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented May 27, 2022

Could I have review of a change that disable TestDevNull.java on Windows.

Testing: jdk/jdk/jfr/api/recording/dump/TestDevNull.java

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287463: JFR: Disable TestDevNull.java on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8929/head:pull/8929
$ git checkout pull/8929

Update a local copy of the PR:
$ git checkout pull/8929
$ git pull https://git.openjdk.java.net/jdk pull/8929/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8929

View PR using the GUI difftool:
$ git pr show -t 8929

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8929.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 27, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287463: JFR: Disable TestDevNull.java on Windows

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 27, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2022

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label May 27, 2022
@egahlin
Copy link
Member Author

@egahlin egahlin commented May 27, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2022

Going to push as commit 0df4748.

@openjdk openjdk bot added the integrated label May 27, 2022
@openjdk openjdk bot closed this May 27, 2022
@openjdk openjdk bot removed the ready label May 27, 2022
@openjdk
Copy link

@openjdk openjdk bot commented May 27, 2022

@egahlin Pushed as commit 0df4748.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 27, 2022

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr integrated
2 participants