Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247957: remove doclint support for HTML 4 #893

Closed
wants to merge 9 commits into from

Conversation

@satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Oct 28, 2020

HTML4 is no longer supported in javadoc.

doclint needs to drop HTML4 support as well.
The changes consist of:

  • Removing -Xhtmlversion option from doclint and --doclint-format from javac.
  • Removing jdk.javadoc.internal.doclint.HtmlVersion and its references.
  • Updating makefile not to use removed option.
  • Sorting out supported tags and attributes in HTML5 (including fix incorrect permission of valign in TH, TR, TD, THEAD and TBODY)
  • Fixing incorrect value checks for the id attribute.
  • Modifying test code and expected outputs to be checked in HTML5

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8247957: remove doclint support for HTML 4
  • JDK-8257204: Remove usage of -Xhtmlversion option from javac
  • JDK-8256313: JavaCompilation.gmk needs to be updated not to use --doclint-format html5 option
  • JDK-8258460: Remove --doclint-format option from javac
  • JDK-8256312: Valid anchor 'id' value not allowed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/893/head:pull/893
$ git checkout pull/893

@bridgekeeper bridgekeeper bot added the oca label Oct 28, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 28, 2020

Hi @satoyoshiki, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user satoyoshiki" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@bridgekeeper bridgekeeper bot removed the oca label Oct 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2020

@satoyoshiki The following labels will be automatically applied to this pull request:

  • compiler
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Generally nice; congratulations on figuring this all out.

Some comments in files need response and/or action.

@@ -27,12 +27,12 @@ dc.anchor.already.defined = \u951A\u5B9A\u70B9\u5DF2\u5B9A\u4E49: "{0}"
dc.anchor.value.missing = \u6CA1\u6709\u4E3A\u951A\u5B9A\u70B9\u6307\u5B9A\u503C
dc.attr.lacks.value = \u5C5E\u6027\u7F3A\u5C11\u503C
dc.attr.not.number = \u5C5E\u6027\u503C\u4E0D\u662F\u6570\u5B57
dc.attr.not.supported.html4 = \u5C5E\u6027\u5728 HTML4 \u4E2D\u4E0D\u53D7\u652F\u6301: {0}

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 12, 2020
Contributor

In general, we (Dev) do not edit any localized resource files. That happens "automatically" by the localization team.

This comment has been minimized.

@satoyoshiki

satoyoshiki Nov 12, 2020
Author

I see. Will discard all changes done in the localized resource files.

public static enum ElemKind {
OK,
INVALID,
OBSOLETE,
UNSUPPORTED
}
Comment on lines 405 to 410

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 12, 2020
Contributor

On one hand, I don't think we need this level of detail, but on the other, I see it closely matches AttrKind, so OK.

Is there are useful distinction between INVALID / OBSOLETE / UNSUPPORTED ?

This comment has been minimized.

@satoyoshiki

satoyoshiki Nov 12, 2020
Author

OK: valid
OBSOLETE: obsolete, deprecated, but still supported (valid)
UNSUPPORTED: ever supported but no longer supported (invalid)
INVALID: the rest of others (invalid)

UNSUPPORTED can be used if we would like to choose a friendly message instead of saying "unknown tag" only.
OBSOLETE is not used anywhere in this commit. Although HTML5 has some obsolete features, JDK-8215577 didn't define them as valid features if my understanding is correct. So I chose not to allow obsolete features in order to avoid inconsistency.

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Dec 17, 2020
Contributor

For both ElemKind and AttrKind there only seem to be two kinds:

  • valid
  • previously valid

For these two cases, OK is obviously reasonable for valid, but OBSOLETE seems a better fit than UNSUPPORTED, but you could also use HTML4 or OLD_HTML4 or something like that to indicate why we're keeping the name around for better messages. Or, stay with UNSUPPORTED but add a doc comment explaining that it was previously supported but no longer supported

This comment has been minimized.

@satoyoshiki

satoyoshiki Dec 17, 2020
Author

Ok, I will use HTML4.

env.messages.error(HTML, tree, "dc.attr.img.border", attr);
}
} catch (NumberFormatException ex) {
env.messages.error(HTML, tree, "dc.attr.img.border", attr);
Comment on lines 689 to 692

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 12, 2020
Contributor

It's generally better practice to use unique message keys at each call site. This is so that if there is a downstream problem when someone reports a problem with an error message, we know the exact single place in the code where the message comes from.

This comment has been minimized.

@satoyoshiki

satoyoshiki Nov 12, 2020
Author

Agreed. I would like to change 675-695 as below

                    case BORDER:
                        if (currTag == HtmlTag.TABLE) {
                            String v = getAttrValue(tree);
                            try {
                                if (v == null || (!v.isEmpty() && Integer.parseInt(v) != 1)) {
                                    env.messages.error(HTML, tree, "dc.attr.table.border.not.valid", attr);
                                }
                            } catch (NumberFormatException ex) {
                                env.messages.error(HTML, tree, "dc.attr.table.border.not.number", attr);
                            }
                        } else if (currTag == HtmlTag.IMG) {
                            String v = getAttrValue(tree);
                            try {
                                if (v == null || (!v.isEmpty() && Integer.parseInt(v) != 0)) {
                                    env.messages.error(HTML, tree, "dc.attr.img.border.not.valid", attr);
                                }
                            } catch (NumberFormatException ex) {
                                env.messages.error(HTML, tree, "dc.attr.img.border.not.number", attr);
                            }
                        }
                        break;
String argVersion = arg.substring(arg.indexOf(":") + 1);
if (argVersion == null || !argVersion.equals("html5")) {
throw new BadArgs("dc.bad.value.for.option", arg, argVersion);
Comment on lines 227 to 229

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 12, 2020
Contributor

It might be friendly to give a warning when this option is used, saying that html5 is the default and only supported version, and that this option may be removed in a future release.

This comment has been minimized.

} else if (arg.startsWith(XHTML_VERSION_PREFIX)) {
String argsVersion = arg.substring(arg.indexOf(":") + 1);
HtmlVersion htmlVersion = HtmlVersion.getHtmlVersion(argsVersion);
if (htmlVersion != null) {
env.setHtmlVersion(htmlVersion);
} else {
throw new IllegalArgumentException(argsVersion);
String argVersion = arg.substring(arg.indexOf(":") + 1);
if (argVersion == null || !argVersion.equals("html5")) {
throw new IllegalArgumentException(argVersion);
Comment on lines 345 to 348

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 12, 2020
Contributor

These lines are only used when invoked from javac/javadoc etc, so it would be reasonable to delete them entirely, provided those tools never try and use this option.

This comment has been minimized.

@satoyoshiki

satoyoshiki Nov 13, 2020
Author

These lines are likely to be used as long as the "--doclint-format html5" option is permitted. For example, this option is still used in the make/common/JavaCompilation.gmk.

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 13, 2020
Contributor

  1. we can update make/common/JavaCompilation.gmk
  2. the option in javac/javadoc should be converted to a no-op so that it does not get passed down to doclint

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 13, 2020
Contributor

(updating make/common/JavaCompilation.gmk should be done with a separate JBS issue, filed against the build.)

This comment has been minimized.

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 26, 2020
Contributor

In javac Arguments class, we should delete these lines at about 855

        String format = options.get(Option.DOCLINT_FORMAT);
        if (format != null) {
            doclintOpts.add(DocLint.XHTML_VERSION_PREFIX + format);
        }

This could be a separate JBS issue, if you prefer.

This comment has been minimized.

TableTagsTest.java:43: error: attribute not supported in HTML5: width
* <table summary="abc" width="50%"> <tr> <td> <tfoot> <tr> </tfoot></table>
^
7 errors

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 12, 2020
Contributor

Does it work to add the final newline: various tools give warnings if files do not end with newline.

This comment has been minimized.

@satoyoshiki

satoyoshiki Nov 12, 2020
Author

It works though. But I will add a blank line at the end for consistency.

TextNotAllowed.java:16: error: attribute not supported in HTML5: summary
* <table summary=description> abc </table>
^
Comment on lines 28 to 30

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 12, 2020
Contributor

The test is 'Text Not Allowed', so the test file should be valid except for text where it is not allowed. Don't add spurious other errors. In this case, provide a <caption> to keep DocLint happy.

This applies throughout this test.

This comment has been minimized.

@satoyoshiki

satoyoshiki Nov 12, 2020
Author

Thanks. I was lacking of such perspective.

InvalidName.java:17: error: invalid name for anchor: "foo()"
* <a name="foo()">invalid</a>
* <a id="foo()">invalid</a>
^
Comment on lines 1 to 3

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 12, 2020
Contributor

This seems incorrect. In HTML5 all names are valid unless they contain whitespace.

This comment has been minimized.

@satoyoshiki

satoyoshiki Nov 13, 2020
Author

Understood. Need to file it as another DocLint bug.

This comment has been minimized.

@@ -1,9 +1,18 @@
TextNotAllowed.java:14: error: attribute not supported in HTML5: summary
* <table summary=description> abc </table>

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Nov 12, 2020
Contributor

See previous comments about spurious error messages

This comment has been minimized.

@@ -1,6 +1,9 @@
TrimmingEmptyTag.java:14: warning: empty <b> tag
* <b></b>
^
TrimmingEmptyTag.java:15: error: attribute not supported in HTML5: summary
* <table summary=description></table>

This comment has been minimized.

This comment has been minimized.

satoyoshiki added 2 commits Dec 10, 2020
8256312: Valid anchor 'id' value not allowed
@satoyoshiki satoyoshiki marked this pull request as ready for review Dec 10, 2020
@openjdk openjdk bot added the rfr label Dec 10, 2020
@satoyoshiki satoyoshiki marked this pull request as draft Dec 10, 2020
@openjdk openjdk bot removed the rfr label Dec 10, 2020
@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Dec 11, 2020

@jonathan-gibbons The new commit includes the changes for your review comments and "8256312: Valid anchor 'id' value not allowed". Please take a look over at your convenience.

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Please make the review non-draft as well

@@ -144,6 +144,8 @@ public void run(PrintWriter out, String... args) throws BadArgs, IOException {
} else if (noFiles) {
out.println(localize("dc.main.no.files.given"));
return;
} else if (useXhtmlVersion) {
System.err.println(localize("dc.main.use.xhtmlversion"));

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Dec 11, 2020
Contributor

use out.println

@@ -356,8 +357,7 @@ public boolean accepts(HtmlTag t) {
TH(BlockType.TABLE_ITEM, EndKind.OPTIONAL,
EnumSet.of(Flag.ACCEPTS_BLOCK, Flag.ACCEPTS_INLINE),
attrs(AttrKind.OK, COLSPAN, ROWSPAN, HEADERS, SCOPE, Attr.ABBR),
attrs(AttrKind.UNSUPPORTED, WIDTH, BGCOLOR, HEIGHT, NOWRAP, AXIS, ALIGN, CHAR, CHAROFF),
attrs(AttrKind.OK, VALIGN)), // Removed after JDK-8255214 fixed.
attrs(AttrKind.UNSUPPORTED, WIDTH, BGCOLOR, HEIGHT, NOWRAP, AXIS, ALIGN, CHAR, CHAROFF, VALIGN)), // Removed after JDK-8255214 fixed.

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Dec 11, 2020
Contributor

remove comment

@@ -372,8 +372,7 @@ public boolean accepts(HtmlTag t) {
TITLE(BlockType.OTHER, EndKind.REQUIRED),

TR(BlockType.TABLE_ITEM, EndKind.OPTIONAL,
attrs(AttrKind.UNSUPPORTED, ALIGN, CHAR, CHAROFF, BGCOLOR),
attrs(AttrKind.OK, VALIGN)) { // Removed after JDK-8255215 fixed
attrs(AttrKind.UNSUPPORTED, ALIGN, CHAR, CHAROFF, BGCOLOR, VALIGN)) { // Removed after JDK-8255215 fixed

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Dec 11, 2020
Contributor

remove comment

@@ -87,6 +88,7 @@ dc.value.not.a.constant=value does not refer to a constant

dc.main.ioerror=IO error: {0}
dc.main.no.files.given=No files given
dc.main.use.xhtmlversion=html5 is the default and only supported version for -XhtmlVersion, and this option may be removed in a future release.

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Dec 11, 2020
Contributor

change version to value
change , and to ;

html5 is the default and only supported value for -XhtmlVersion; this option may be removed in a future release.
@satoyoshiki satoyoshiki marked this pull request as ready for review Dec 11, 2020
@openjdk openjdk bot added the rfr label Dec 11, 2020
@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Dec 11, 2020

Thanks for reviewing @jonathan-gibbons
This request should have got changed to "non-draft".

FYI. all tests in jdk-tier1 are still green with the latest changes.
https://mach5.us.oracle.com/mdash/jobs/yoshiki-jdk-20201211-0555-16616611

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 11, 2020

@openjdk openjdk bot added the build label Dec 15, 2020
@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Dec 15, 2020

This commit includes the changes for
8257204: Remove usage of -Xhtmlversion option from javac
8256313: JavaCompilation.gmk needs to be updated not to use --doclint-format html5 option

The changes presume the changes made by a 8247957. And there is no need to separate them from 8247957, so I would like to pull all changes into this.

Copy link
Member

@magicus magicus left a comment

Build change look fine. I have not looked at the other changes.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2020

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8247957: remove doclint support for HTML 4
8257204: Remove usage of -Xhtmlversion option from javac
8256313: JavaCompilation.gmk needs to be updated not to use --doclint-format html5 option
8258460: Remove --doclint-format option from javac
8256312: Valid anchor 'id' value not allowed

Reviewed-by: jjg, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 97c99b5: 8216400: improve handling of IOExceptions in JavaCompiler.close()
  • b575dd8: 8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons, @magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 15, 2020
@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Dec 16, 2020

I found an issue when called from javac, so will convert to draft until the issue resolved.

@satoyoshiki satoyoshiki marked this pull request as draft Dec 16, 2020
@openjdk openjdk bot removed the rfr label Dec 16, 2020
8257204: Remove usage of -Xhtmlversion option from javac
8256313: JavaCompilation.gmk needs to be updated not to use --doclint-format html5 option
@satoyoshiki satoyoshiki marked this pull request as ready for review Dec 21, 2020
@openjdk openjdk bot added the rfr label Dec 21, 2020
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Looks good.
I'll pull down a copy, for review in an IDE and to build and run tests, and if that goes OK, I will approve it.

.B \f[CB]\-\-doclint\-format\f[R] [\f[CB]html4\f[R]|\f[CB]html5\f[R]]
Specifies the format for documentation comments.
.RS
.RE
.TP
Comment on lines 634 to 638

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Dec 23, 2020
Contributor

In general, you should not edit files like this; these files are generated from upstream Markdown files.

This comment has been minimized.

@satoyoshiki

satoyoshiki Dec 23, 2020
Author

Ok. I will revert this with the next commit.

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

One must-fix item (bad pattern constant.)

// http://www.w3.org/TR/html401/types.html#type-name
private static final Pattern validName = Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*");
// https://html.spec.whatwg.org/#the-id-attribute
private static final Pattern validId = Pattern.compile("[^\s]+");

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Dec 23, 2020
Contributor

The regular expression is invalid and needs to be fixed. It should be Pattern.compile("[^\\s]+")
Note the extra \ character. This is because you need to escape the \ character in the string constant, so that the \ is seen in the pattern as part of \s.

This comment has been minimized.

@satoyoshiki

satoyoshiki Dec 23, 2020
Author

Correct. Thanks a lot for finding this error.
Now that I have doubts why this line could have been compiled without error. This line should cause a compiler error.

Let me review all anchor tests again because the logic should be checked there.

This comment has been minimized.

@satoyoshiki

satoyoshiki Dec 23, 2020
Author

For some reason, "[^\s]+" might have been dealt with as a text block, thus \s was regarded as a whitespace...
I believe a text block is defined with triple double quotes, but javac seems to accept "[^\s]+" as a text block.

That aside, all anchor tests look fine. This is because there is no specific test to use whitespace characters such as \n, \t, \r and \f in an anchor name. Also I confirmed the discrepancy of the results for "[^\s]+" and "[^\\s]+". It shows that the former is not exactly what we want to do.

$ jshell -J-Duser.language=en -J--show-version
java 15 2020-09-15
Java(TM) SE Runtime Environment (build 15+36-1562)
Java HotSpot(TM) 64-Bit Server VM (build 15+36-1562, mixed mode, sharing)
| Welcome to JShell -- Version 15
| For an introduction type: /help intro

jshell> Pattern validId1 = Pattern.compile("[^\s]+")
validId1 ==> [^ ]+

jshell> Pattern validId2 = Pattern.compile("[^\s]+")
validId2 ==> [^\s]+

jshell> validId1.matcher("aaa").matches()
$3 ==> true

jshell> validId1.matcher("aaa ").matches()
$4 ==> false

jshell> validId1.matcher("aaa\n").matches()
$5 ==> true

jshell> validId2.matcher("aaa").matches()
$6 ==> true

jshell> validId2.matcher("aaa ").matches()
$7 ==> false

jshell> validId2.matcher("aaa\n").matches()
$8 ==> false

env.messages.error(HTML, tree, "dc.attr.not.supported.html5", name);
break;
}
}

private boolean checkAnchor(String name) {

This comment has been minimized.

@jonathan-gibbons

jonathan-gibbons Dec 23, 2020
Contributor

I was going to let it slide for this round of cleanup, but if you're editing this file again (see comment on line 736) it might be worth changing the use of anchor to id. anchor is a term that was more appropriate in the days before the id attribute, when we used <a name="...">. This is an optional suggestion. It might equally be worth focussing on the must-fix items, and postpone this cleanup for later.

This comment has been minimized.

@satoyoshiki

satoyoshiki Dec 23, 2020
Author

I understand. But is it really no problem to be done in part of the cleanup of doclint?
Looking at the classes in jdk/javadoc/internal/doclint, the term (anchor|Anchor) looks like only used in Checker.java and resource files. But a lot of other files, for instance in jdk/javadoc/internal/doclets, use this term to refer to the id or name attribute. I would be fine if it is supposed to be done in each cleanup in the future.

This comment has been minimized.

@satoyoshiki

satoyoshiki Dec 23, 2020
Author

If we would apply similar changing to doclint.properties, what you are thinking is like below right?

-dc.anchor.already.defined = anchor already defined: "{0}"
-dc.anchor.value.missing = no value given for anchor
+dc.id.already.defined = attribute "id" already defined: "{0}"
+dc.id.value.missing = no value given for attribute "id"

-dc.invalid.anchor = invalid name for anchor: "{0}"
-dc.invalid.id = invalid name for attribute "id": "{0}"
@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Dec 23, 2020

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Dec 23, 2020

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Dec 23, 2020

@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Dec 24, 2020

\s was introduced as a valid escape character in JDK 15 as part of the support for Text Blocks. https://docs.oracle.com/javase/specs/jls/se15/html/jls-3.html#jls-EscapeSequence https://docs.oracle.com/javase/specs/jls/se14/preview/specs/text-blocks-jls.html#jls-3.10.7 FWIW, the escape sequence showed up with red squiggly lines in my IDE.

Ok. I didn't know that. When I change my project SDK to 14, the escape sequence showed up with red squiggly.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 25, 2020

@satoyoshiki this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8247957_2
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
@openjdk openjdk bot added merge-conflict and removed ready labels Dec 25, 2020
@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Dec 25, 2020

/issue add 8257204, 8256313, 8258460, 8256312

@openjdk
Copy link

@openjdk openjdk bot commented Dec 25, 2020

@satoyoshiki
Adding additional issue to issue list: 8257204: Remove usage of -Xhtmlversion option from javac.

Adding additional issue to issue list: 8256313: JavaCompilation.gmk needs to be updated not to use --doclint-format html5 option.

Adding additional issue to issue list: 8258460: Remove --doclint-format option from javac.

Adding additional issue to issue list: 8256312: Valid anchor 'id' value not allowed.

@openjdk openjdk bot added ready and removed merge-conflict labels Dec 25, 2020
@satoyoshiki
Copy link
Author

@satoyoshiki satoyoshiki commented Dec 28, 2020

/integrate

@openjdk openjdk bot added the sponsor label Dec 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 28, 2020

@satoyoshiki
Your change (at version c5f7af8) is now ready to be sponsored by a Committer.

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jan 6, 2021

/sponsor

@openjdk openjdk bot closed this Jan 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2021

@jonathan-gibbons @satoyoshiki Since your change was applied there have been 52 commits pushed to the master branch:

  • 80544e4: 8250564: Remove terminally deprecated constructor in GSSUtil
  • 940b053: 8259232: Bad JNI lookup during printing
  • df721f0: 8259291: Cleanup unnecessary local variables
  • d20d2fa: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later
  • 3be6e06: 8259312: VerifyCACerts.java fails as soneraclass2ca cert will expire in 90 days
  • 722f236: 8259231: Epsilon: improve performance under contention during virtual space expansion
  • f6cb8c5: 8258908: Remove JVM option CleanChunkPoolAsync
  • c0540ff: 8231627: ThreadsListHandleInErrorHandlingTest.java fails in printing all threads
  • 7e01bc9: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows
  • 8a05d60: 8259042: Inconsistent use of general primitives loops
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/57217b58bfd28c7ccbc0c3602e878c085dd865b9...master

Your commit was automatically rebased without conflicts.

Pushed as commit 28e1f4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants