Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287492: ProblemList compiler/jvmci/errors/TestInvalidDebugInfo.java #8932

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented May 28, 2022

Please review so we can cleanup the noise in our CI.

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287492: ProblemList compiler/jvmci/errors/TestInvalidDebugInfo.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8932/head:pull/8932
$ git checkout pull/8932

Update a local copy of the PR:
$ git checkout pull/8932
$ git pull https://git.openjdk.java.net/jdk pull/8932/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8932

View PR using the GUI difftool:
$ git pr show -t 8932

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8932.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2022

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 28, 2022
@openjdk
Copy link

openjdk bot commented May 28, 2022

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dholmes-ora
Copy link
Member Author

dholmes-ora commented May 28, 2022

/label add hotspot-dev

@openjdk openjdk bot added the hotspot label May 28, 2022
@openjdk
Copy link

openjdk bot commented May 28, 2022

@dholmes-ora
The hotspot label was successfully added.

@dholmes-ora
Copy link
Member Author

dholmes-ora commented May 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2022

@dholmes-ora This pull request has not yet been marked as ready for integration.

vidmik
vidmik approved these changes May 28, 2022
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

openjdk bot commented May 28, 2022

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287492: ProblemList compiler/jvmci/errors/TestInvalidDebugInfo.java

Reviewed-by: mikael, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 28, 2022
@dholmes-ora
Copy link
Member Author

dholmes-ora commented May 28, 2022

/integrate

Thanks @vidmik and @vnkozlov !

@openjdk
Copy link

openjdk bot commented May 28, 2022

Going to push as commit 2c461ac.

@openjdk openjdk bot added integrated and removed ready rfr labels May 28, 2022
@openjdk
Copy link

openjdk bot commented May 28, 2022

@dholmes-ora Pushed as commit 2c461ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented May 28, 2022

Webrevs

@dholmes-ora dholmes-ora deleted the 8287492 branch Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
3 participants