8236569: -Xss not multiple of 4K does not work for the main thread on macOS

[asotona]

This is continuation of PR #4256

The patch simply rounds up the specified stack size to multiple of the system page size, on systems where necessary.
The patch is based on the original PR/branch, with reflected remaining recommendations.

Please review.

Thank you,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8236569: -Xss not multiple of 4K does not work for the main thread on macOS

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8953/head:pull/8953
$ git checkout pull/8953

Update a local copy of the PR:
$ git checkout pull/8953
$ git pull https://git.openjdk.java.net/jdk pull/8953/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8953

View PR using the GUI difftool:
$ git pr show -t 8953

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8953.diff

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7712f700)
• 00: Full (d082aed0)

[dholmes-ora]

Changes looks good. But the java manpage needs an update too.

Thanks,
David

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8236569: -Xss not multiple of 4K does not work for the main thread on macOS

Reviewed-by: dholmes, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 3deb58a: 8287318: ConcurrentModificationException in sun.net.httpserver.ServerImpl$Dispatcher
• 8fc201e: 8285939: javadoc java.lang.Record should not have "Direct Known Subclasses:" section
• f5bbade: 8287544: Replace uses of StringBuffer with StringBuilder in java.naming
• 97bd4c2: 8286159: Memory leak in getAllConfigs of awt_GraphicsEnv.c:585
• 8db5247: 8282771: Create test case for JDK-8262981
• cfdbde1: 8282778: Create a regression test for JDK-4699544
• 8df5f10: 8282857: Create a regression test for JDK-4702690
• e0382c5: 8285401: Proxy class initializer should use 3-arg Class.forName to avoid unnecessary class initialization
• 37a5130: 8287064: Modernize ProxyGenerator.PrimitiveTypeInfo
• d5b6c7b: 8287384: Speed up jdk.test.lib.util.ForceGC
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/8f59422d357a00a2270a8f421966977e3979c2fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Thanks for the manpage update!

[tstuefe]

Looks good.

[asotona]

/integrate

[openjdk]

Going to push as commit 7846971.
Since your change was applied there have been 17 commits pushed to the master branch:

• 7159976: 8287520: Shrink x86_32 problemlists after JDK-8287437
• 3deb58a: 8287318: ConcurrentModificationException in sun.net.httpserver.ServerImpl$Dispatcher
• 8fc201e: 8285939: javadoc java.lang.Record should not have "Direct Known Subclasses:" section
• f5bbade: 8287544: Replace uses of StringBuffer with StringBuilder in java.naming
• 97bd4c2: 8286159: Memory leak in getAllConfigs of awt_GraphicsEnv.c:585
• 8db5247: 8282771: Create test case for JDK-8262981
• cfdbde1: 8282778: Create a regression test for JDK-4699544
• 8df5f10: 8282857: Create a regression test for JDK-4702690
• e0382c5: 8285401: Proxy class initializer should use 3-arg Class.forName to avoid unnecessary class initialization
• 37a5130: 8287064: Modernize ProxyGenerator.PrimitiveTypeInfo
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/8f59422d357a00a2270a8f421966977e3979c2fb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit 7846971.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.