Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287740 NSAccessibilityShowMenuAction not working for text editors #8997

Closed
wants to merge 2 commits into from

Conversation

savoptik
Copy link
Contributor

@savoptik savoptik commented Jun 2, 2022

The NSAccessibilityShouMinuAction action does not show the menu for the text element.
Steps to reproduce:

  1. redefine the accessible context with the addition of the toggle popup action;
  2. run on macOS with VoiceOver enabled;
  3. try to call the context menu in the editor by pressing vo+shift+m.

@azuev-java please review.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287740: NSAccessibilityShowMenuAction not working for text editors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8997/head:pull/8997
$ git checkout pull/8997

Update a local copy of the PR:
$ git checkout pull/8997
$ git pull https://git.openjdk.java.net/jdk pull/8997/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8997

View PR using the GUI difftool:
$ git pr show -t 8997

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8997.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2022

👋 Welcome back asemenov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 2, 2022
@openjdk
Copy link

openjdk bot commented Jun 2, 2022

@savoptik The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 2, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2022

Webrevs

Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jun 3, 2022

@savoptik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287740: NSAccessibilityShowMenuAction not working for text editors

Reviewed-by: kizune, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 7a0c8b1: 8286850: [macos] Add support for signing user provided app image
  • 0b35460: 8283694: Improve bit manipulation and boolean to integer conversion operations on x86_64
  • a0219da: 8287517: C2: assert(vlen_in_bytes == 64) failed: 2
  • ce5ae51: 8287637: Loom: Mismatched VirtualThread::state accessor
  • 59e9700: 8252717: Integrate/merge legacy standard doclet diagnostics and doclint
  • 28c112f: 8287685: [BACKOUT] JDK-8287384 Speed up jdk.test.lib.util.ForceGC
  • 34bb0a5: 8287734: Shenandoah: Consolidate marking closures
  • 33b9d77: 8287729: Loom: Check alternative implementation on x86_32
  • a75299c: 8287686: Add assertion to ensure that disarm value offset < 128
  • 407abf5: 8233477: [Win LAF]The tooltip doesn't display correctly in Win LAF
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/5acac2238fdc4ffe6ef290456e01cc559d811557...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 3, 2022
private void createEditableTextArea() {
AccessibleComponentTest.INSTRUCTIONS = "INSTRUCTIONS:\n"
+ "Check a11y show context menu in editable JTextArea.\n\n"
+ "Turn screen reader on and press Tab to move to the text area and vo+shif+m.\n\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, can we use the same style of instructions, the previous tests use a separate text to press the VO shortcuts, here it could be something like this:
"Turn screen reader on and press Tab to move to the text area"
"Perform the VO action "Open a shortcut menu" (VO+Shift+m)\n\n"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

…ious tests use a separate text to press the VO shortcuts, here it could be something like this:

"Turn screen reader on and press Tab to move to the text area"
"Perform the VO action "Open a shortcut menu" (VO+Shift+m)\n\n"
@savoptik
Copy link
Contributor Author

savoptik commented Jun 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 3, 2022

Going to push as commit b6cdfd6.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 25e9901: 8285305: Create an automated test for JDK-4495286
  • 6f526e1: 8285373: Create an automated test for JDK-4702233
  • a7e07fd: 8287102: ImageReaderSpi.canDecodeInput() for standard plugins should return false if a stream is too short
  • 7a0c8b1: 8286850: [macos] Add support for signing user provided app image
  • 0b35460: 8283694: Improve bit manipulation and boolean to integer conversion operations on x86_64
  • a0219da: 8287517: C2: assert(vlen_in_bytes == 64) failed: 2
  • ce5ae51: 8287637: Loom: Mismatched VirtualThread::state accessor
  • 59e9700: 8252717: Integrate/merge legacy standard doclet diagnostics and doclint
  • 28c112f: 8287685: [BACKOUT] JDK-8287384 Speed up jdk.test.lib.util.ForceGC
  • 34bb0a5: 8287734: Shenandoah: Consolidate marking closures
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/5acac2238fdc4ffe6ef290456e01cc559d811557...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2022
@openjdk openjdk bot closed this Jun 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 3, 2022
@openjdk
Copy link

openjdk bot commented Jun 3, 2022

@savoptik Pushed as commit b6cdfd6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants