8027545: Improve object array chunking test in G1's copy_to_survivor_space #90
/issue add JDK-8158045
This is rework of initial change from before the transition to git.
The primary change is to limit the number of partial array tasks in
Most of the calculation for this is handled by a new helper class, so
The dispatch on array klass type for has also been changed. It now
Ran tier1-6 in mach5 and some local stress tests.
Performance testing was unchanged from previous, except I wasn't able
--- Initial RFR email ---
RFR: 8158045: Improve large object handling during evacuation
Please review this change to type dispatching and handling in G1's
do_copy_to_survivor_space now gets the klass of the object being copied
Moved check for and handling of string deduplication later, only applying it
Special case typeArray, doing nothing other than the copy, since they
Changed handling of objArray, pushing all of the partial array tasks up
As part of these, cached some more frequently accessed values in
While both the old and new code will work for Project Valhalla, the handling
Deleted a lingering reference to G1ParScanPartialArrayClosure that was
performance testing - seems to be at worst performance neutral, with a
The text was updated successfully, but these errors were encountered:
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the
Well, that discussion is only ?above" in the github UI tool.
Now that I see what happens when I reply there, maybe I won?t do that so much.
After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 49 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
On 11.09.20 11:01, Kim Barrett wrote:
s/_task_fannout/_task_fanout (or maybe _task_fan_out)
- since _task_fannout and _task_limit are only assigned in the
- also the asserts in PartialArrayTaskStepper::next_impl could be
Looks good otherwise.
Thanks, will do.
Yeah, changed return type from void to int at some point and missed adjusting the indentation.
I thought it looked a little odd at first, but never got around to spell
I'd rather not. I've been down that road and didn't like the results. Just
As you say, the current location shows the requirements for the nearby
Adding additional issue to issue list:
On 12.09.20 03:02, Kim Barrett wrote:
Okay. Going to mark this as reviewed assuming the rename will be done.
@kimbarrett Since your change was applied there have been 49 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit dafcf10.