Skip to content

8250950: Allow per-user and system wide configuration of a jpackaged app #9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Jun 3, 2022


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8250950: Allow per-user and system wide configuration of a jpackaged app
  • JDK-8287060: Allow per-user and system wide configuration of a jpackaged app (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/9025/head:pull/9025
$ git checkout pull/9025

Update a local copy of the PR:
$ git checkout pull/9025
$ git pull https://git.openjdk.java.net/jdk pull/9025/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9025

View PR using the GUI difftool:
$ git pr show -t 9025

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/9025.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2022

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 3, 2022

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 3, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 3, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2022

Webrevs

@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev please resume the review

@openjdk
Copy link

openjdk bot commented Jun 6, 2022

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8250950: Allow per-user and system wide configuration of a jpackaged app

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • e94b05c: 8285285: Avoid redundant allocations in WindowsPreferences
  • 3eb49fe: 8287766: Unnecessary Vector usage in LdapClient
  • 2e332c2: 8287671: Adjust ForceGC to invoke System::gc fewer times for negative case
  • c328f8f: 8287764: runtime/cds/serviceability/ReplaceCriticalClasses failed on localized Windows
  • 4d6fb51: 8287524: Improve checkboxes to select releases on deprecated API page
  • 0d1a305: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on x86_32 after JDK-8287496
  • 24fe8ad: 8283307: Vectorize unsigned shift right on signed subword types
  • f347ff9: 8283894: Intrinsify compress and expand bits on x86
  • ebc012e: 8287205: generate_cont_thaw generates dead code after jump to exception handler
  • 8c460b0: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative
  • ... and 77 more: https://git.openjdk.java.net/jdk/compare/6f6486e97743eadfb20b4175e1b4b2b05b59a17a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 6, 2022
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2022

Going to push as commit c37c8e5.
Since your change was applied there have been 91 commits pushed to the master branch:

  • 124ba45: 8287101: CDS should check for file truncation for all regions
  • 0e06bf3: 8287838: Update Float and Double to use snippets
  • a277590: 8287761: Make the logging of J2DBench stable
  • 5264881: 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard
  • e94b05c: 8285285: Avoid redundant allocations in WindowsPreferences
  • 3eb49fe: 8287766: Unnecessary Vector usage in LdapClient
  • 2e332c2: 8287671: Adjust ForceGC to invoke System::gc fewer times for negative case
  • c328f8f: 8287764: runtime/cds/serviceability/ReplaceCriticalClasses failed on localized Windows
  • 4d6fb51: 8287524: Improve checkboxes to select releases on deprecated API page
  • 0d1a305: 8287732: jdk/jshell/ToolEnablePreviewTest.java fails on x86_32 after JDK-8287496
  • ... and 81 more: https://git.openjdk.java.net/jdk/compare/6f6486e97743eadfb20b4175e1b4b2b05b59a17a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2022
@openjdk openjdk bot closed this Jun 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2022
@openjdk
Copy link

openjdk bot commented Jun 6, 2022

@alexeysemenyukoracle Pushed as commit c37c8e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants