Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Jun 4, 2022

The typo in the @run tag is fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287824: The MTPerLineTransformValidation tests has a typo in the @run tag

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/9030/head:pull/9030
$ git checkout pull/9030

Update a local copy of the PR:
$ git checkout pull/9030
$ git pull https://git.openjdk.java.net/jdk pull/9030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9030

View PR using the GUI difftool:
$ git pr show -t 9030

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/9030.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 4, 2022

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 4, 2022
@mrserb mrserb marked this pull request as ready for review June 4, 2022 20:49
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 5, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287824: The MTPerLineTransformValidation tests has a typo in the @run tag

Reviewed-by: iris, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 8c460b0: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative
  • 3df4b03: 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp
  • a6fc485: 8287753: [spelling] close well-established compounds

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 5, 2022
@mrserb
Copy link
Member Author

mrserb commented Jun 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2022

Going to push as commit 645be42.
Since your change was applied there have been 18 commits pushed to the master branch:

  • a50b06e: 8287867: Bad merge of jdk/test/lib/util/ForceGC.java causing test compilation error
  • c37c8e5: 8250950: Allow per-user and system wide configuration of a jpackaged app
  • 124ba45: 8287101: CDS should check for file truncation for all regions
  • 0e06bf3: 8287838: Update Float and Double to use snippets
  • a277590: 8287761: Make the logging of J2DBench stable
  • 5264881: 8286481: Exception printed to stdout on Windows when storing transparent image in clipboard
  • e94b05c: 8285285: Avoid redundant allocations in WindowsPreferences
  • 3eb49fe: 8287766: Unnecessary Vector usage in LdapClient
  • 2e332c2: 8287671: Adjust ForceGC to invoke System::gc fewer times for negative case
  • c328f8f: 8287764: runtime/cds/serviceability/ReplaceCriticalClasses failed on localized Windows
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/a113e166e91b9b3d3f74a284888a5135b48dad44...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2022
@openjdk openjdk bot closed this Jun 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2022
@openjdk
Copy link

openjdk bot commented Jun 6, 2022

@mrserb Pushed as commit 645be42.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8287824 branch June 6, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants