Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287818: Shenandoah: adapt nmethod arming from Loom #9048

Closed
wants to merge 6 commits into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jun 6, 2022

Loom implemented nmethod arming mechanism, which is very similar to Shenandoah's. Shenandoah can use it.

Test:

  • hotspot_gc_shenandoah on Linux x86_64 and Windows x64
  • tier1 with Shenandoah GC on Linux x86_64 and Windows x64
  • hotspot_gc_shenandoah on AArch64

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287818: Shenandoah: adapt nmethod arming from Loom

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9048/head:pull/9048
$ git checkout pull/9048

Update a local copy of the PR:
$ git checkout pull/9048
$ git pull https://git.openjdk.org/jdk pull/9048/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9048

View PR using the GUI difftool:
$ git pr show -t 9048

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9048.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 6, 2022
@openjdk
Copy link

openjdk bot commented Jun 6, 2022

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jun 6, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2022

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine to me, but I have questions.

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287818: Shenandoah: adapt nmethod arming from Loom

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • e322e77: 8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name
  • 40bf3b1: 8288993: Make AwtFramePackTest generic by removing @requires tag
  • d4b040f: Merge
  • 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
  • 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
  • 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
  • 20f55ab: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support
  • bdf9902: 8288120: VerifyError with JEP 405 pattern match
  • b0db333: 8288528: broken links in java.desktop
  • 651cbeb: 8288080: (fc) FileChannel::map for MemorySegments should state it always throws UOE
  • ... and 37 more: https://git.openjdk.org/jdk/compare/26c03c1860c6da450b5cd6a46576c78bea682f96...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2022
@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 28, 2022

Going to push as commit 549c6c2.
Since your change was applied there have been 52 commits pushed to the master branch:

  • aa43824: 8289138: G1: Remove redundant is-marking-active checks in C1 barrier
  • b4ab5fe: 8288396: Always create reproducible builds
  • 3336971: 8289258: ProblemList some failing custom loader tests with ZGC
  • 784fa0a: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
  • ca78f7b: 8286259: Password cleanup after KeyStore.PasswordProtection in P11KeyStore
  • e322e77: 8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name
  • 40bf3b1: 8288993: Make AwtFramePackTest generic by removing @requires tag
  • d4b040f: Merge
  • 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
  • 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
  • ... and 42 more: https://git.openjdk.org/jdk/compare/26c03c1860c6da450b5cd6a46576c78bea682f96...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 28, 2022
@openjdk openjdk bot closed this Jun 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 28, 2022
@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@zhengyu123 Pushed as commit 549c6c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123 zhengyu123 deleted the 8287818-nmethod-arming branch July 14, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants