8287818: Shenandoah: adapt nmethod arming from Loom#9048
8287818: Shenandoah: adapt nmethod arming from Loom#9048zhengyu123 wants to merge 6 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
|
@zhengyu123 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
shipilev
left a comment
There was a problem hiding this comment.
Looks mostly fine to me, but I have questions.
src/hotspot/share/gc/shenandoah/shenandoahBarrierSetNMethod.cpp
Outdated
Show resolved
Hide resolved
|
@zhengyu123 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 47 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 549c6c2.
Your commit was automatically rebased without conflicts. |
|
@zhengyu123 Pushed as commit 549c6c2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Loom implemented nmethod arming mechanism, which is very similar to Shenandoah's. Shenandoah can use it.
Test:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9048/head:pull/9048$ git checkout pull/9048Update a local copy of the PR:
$ git checkout pull/9048$ git pull https://git.openjdk.org/jdk pull/9048/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9048View PR using the GUI difftool:
$ git pr show -t 9048Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9048.diff