Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable #9051

Closed
wants to merge 3 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 7, 2022

This is an update of the test which was de-problemlisted here.

Looks like the initial root cause of the issue was related to the last disposed frame which for some reason was not deleted from the memory, for that issue, the next bug was reported.
But that change also replaced the usage of weak references by the Runtime.getRuntime().freeMemory() which is not stable enough to verify the leak - its return values vary a lot.

This change returns the usage of weak references and tests only one instance of TitledBorder which is enough to verify the old bug.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/9051/head:pull/9051
$ git checkout pull/9051

Update a local copy of the PR:
$ git checkout pull/9051
$ git pull https://git.openjdk.java.net/jdk pull/9051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9051

View PR using the GUI difftool:
$ git pr show -t 9051

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/9051.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 7, 2022
@mrserb mrserb marked this pull request as ready for review June 7, 2022 05:12
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable

Reviewed-by: psadhukhan, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • b7a34f7: 8287927: ProblemList java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on macosx-aarch64
  • 8e07839: 8285081: Improve XPath operators count accuracy
  • b12e7f1: 8279358: vmTestbase/nsk/jvmti/scenarios/jni_interception/JI03/ji03t003/TestDescription.java fails with usage tracker
  • 1aa87e0: 8287148: Avoid redundant HashMap.containsKey calls in ExtendedKeyCodes.getExtendedKeyCodeForChar
  • 74be2d9: 8286983: rename jdb -trackvthreads and debug agent enumeratevthreads options and clarify "Preview Feature" nature of these options
  • 8e10c2b: 8287877: Exclude vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java until JDK-8277573 is fixed
  • 9ec27d0: 8287872: Disable concurrent execution of hotspot docker tests
  • 91e6bf6: 8287919: ProblemList java/lang/CompressExpandTest.java
  • 3da7e39: 8287840: Dead copy region node blocks IfNode's fold-compares
  • c41a283: 8273853: Update the Java manpage for automatic CDS archive updating
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/ef7cc2105c66de443d3a9af706220272018a0d8d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2022
@mrserb
Copy link
Member Author

mrserb commented Jun 7, 2022

I have found that the simpler version of the test can be used to verify that old bug. the patch is updated.

@mrserb
Copy link
Member Author

mrserb commented Jun 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 7, 2022

Going to push as commit bf439f8.
Since your change was applied there have been 33 commits pushed to the master branch:

  • b7a34f7: 8287927: ProblemList java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on macosx-aarch64
  • 8e07839: 8285081: Improve XPath operators count accuracy
  • b12e7f1: 8279358: vmTestbase/nsk/jvmti/scenarios/jni_interception/JI03/ji03t003/TestDescription.java fails with usage tracker
  • 1aa87e0: 8287148: Avoid redundant HashMap.containsKey calls in ExtendedKeyCodes.getExtendedKeyCodeForChar
  • 74be2d9: 8286983: rename jdb -trackvthreads and debug agent enumeratevthreads options and clarify "Preview Feature" nature of these options
  • 8e10c2b: 8287877: Exclude vmTestbase/nsk/jvmti/AttachOnDemand/attach022/TestDescription.java until JDK-8277573 is fixed
  • 9ec27d0: 8287872: Disable concurrent execution of hotspot docker tests
  • 91e6bf6: 8287919: ProblemList java/lang/CompressExpandTest.java
  • 3da7e39: 8287840: Dead copy region node blocks IfNode's fold-compares
  • c41a283: 8273853: Update the Java manpage for automatic CDS archive updating
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/ef7cc2105c66de443d3a9af706220272018a0d8d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 7, 2022
@openjdk openjdk bot closed this Jun 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@mrserb Pushed as commit bf439f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8287876 branch June 13, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants