-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable #9051
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
Webrevs
|
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 33 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
I have found that the simpler version of the test can be used to verify that old bug. the patch is updated. |
/integrate |
Going to push as commit bf439f8.
Your commit was automatically rebased without conflicts. |
This is an update of the test which was de-problemlisted here.
Looks like the initial root cause of the issue was related to the last disposed frame which for some reason was not deleted from the memory, for that issue, the next bug was reported.
But that change also replaced the usage of weak references by the Runtime.getRuntime().freeMemory() which is not stable enough to verify the leak - its return values vary a lot.
This change returns the usage of weak references and tests only one instance of TitledBorder which is enough to verify the old bug.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/9051/head:pull/9051
$ git checkout pull/9051
Update a local copy of the PR:
$ git checkout pull/9051
$ git pull https://git.openjdk.java.net/jdk pull/9051/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9051
View PR using the GUI difftool:
$ git pr show -t 9051
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/9051.diff