Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287908: Use non-cloning reflection methods where acceptable #9064

Closed
wants to merge 3 commits into from

Conversation

stsypanov
Copy link
Contributor

@stsypanov stsypanov commented Jun 7, 2022

Instead of Executable.getParameterTypes() we could use Executable.getSharedParameterTypes() in trusted code. Same is applicable for Executable.getExceptionTypes().


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287908: Use non-cloning reflection methods where acceptable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9064/head:pull/9064
$ git checkout pull/9064

Update a local copy of the PR:
$ git checkout pull/9064
$ git pull https://git.openjdk.org/jdk pull/9064/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9064

View PR using the GUI difftool:
$ git pr show -t 9064

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9064.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2022

👋 Welcome back stsypanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@stsypanov The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 7, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2022

@stsypanov This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@stsypanov
Copy link
Contributor Author

Let's wait

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2022

@stsypanov This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@stsypanov
Copy link
Contributor Author

Let's wait a bit

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2022

@stsypanov This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@stsypanov
Copy link
Contributor Author

@RogerRiggs is there anything I can do about this in addition to what is already done?

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.
I was expecting another reviewer to chime in.
(BTW, the change isn't so interesting that reviewers have jumped on the chance).

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

⚠️ @stsypanov the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8287908
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@stsypanov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287908: Use non-cloning reflection methods where acceptable

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1131 new commits pushed to the master branch:

  • 46e6e41: 8293051: Further refactor javac after removal of -source/-target/--release 7
  • c0ee30a: 8293348: A false cyclic inheritance error reported
  • 85ec1f8: 8293492: ShenandoahControlThread missing from hs-err log and thread dump
  • 6bd2794: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT
  • 98da03a: 8293432: Use diamond operator in java.management
  • ffc249a: 8289613: Drop use of Thread.stop in jshell
  • 8d3399b: 8292758: put support for UNSIGNED5 format into its own header file
  • 6677227: 8293497: Build failure due to MaxVectorSize was not declared when C2 is disabled after JDK-8293254
  • 986b834: 8293489: Accept CAs with BasicConstraints without pathLenConstraint
  • fc5f97f: 8293474: RISC-V: Unify the way of moving function pointer
  • ... and 1121 more: https://git.openjdk.org/jdk/compare/d959c22a9574359e2d5134ac8365e8a9df4f7cef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2022
@stsypanov
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 8, 2022
@openjdk
Copy link

openjdk bot commented Sep 8, 2022

@stsypanov
Your change (at version 7ef88f8) is now ready to be sponsored by a Committer.

@RogerRiggs
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 12, 2022

Going to push as commit 9ef6c09.
Since your change was applied there have been 1153 commits pushed to the master branch:

  • 0c61bf1: 8293282: LoadLibraryUnloadTest.java fails with "Too few cleared WeakReferences"
  • 91c9091: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
  • 4c77bd3: 6529151: NullPointerException in swing.plaf.synth.SynthLookAndFeel$Handler
  • d5aae01: 8293544: G1: Add comment in G1BarrierSetC1::pre_barrier
  • 37df5f5: 8291599: Assertion in PhaseIdealLoop::skeleton_predicate_has_opaque after JDK-8289127
  • 699c429: 8292866: Java_sun_awt_shell_Win32ShellFolder2_getLinkLocation check MultiByteToWideChar return value for failures
  • 68da02c: 8292240: CarrierThread.blocking not reset when spare not activated
  • 005b49b: 8293044: C1: Missing access check on non-accessible class
  • 91d00b3: 8288473: Remove unused frame::set_pc_preserve_deopt methods
  • 45ff10c: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • ... and 1143 more: https://git.openjdk.org/jdk/compare/d959c22a9574359e2d5134ac8365e8a9df4f7cef...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 12, 2022
@openjdk openjdk bot closed this Sep 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 12, 2022
@openjdk
Copy link

openjdk bot commented Sep 12, 2022

@RogerRiggs @stsypanov Pushed as commit 9ef6c09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stsypanov stsypanov deleted the 8287908 branch September 12, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants