Skip to content

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 7, 2022

A trivial fix to ProblemList java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on macosx-aarch64.

What I'd really like to is to ProblemList this test
on Mac_OS_X_12.4 and Mac_OS_X_12.5, but two digit release values
(M.N) did not work when I tried them a month or so ago.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287927: ProblemList java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on macosx-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/9071/head:pull/9071
$ git checkout pull/9071

Update a local copy of the PR:
$ git checkout pull/9071
$ git pull https://git.openjdk.java.net/jdk pull/9071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9071

View PR using the GUI difftool:
$ git pr show -t 9071

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/9071.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add client

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review June 7, 2022 20:34
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@dcubed-ojdk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 7, 2022

Webrevs

@aivanov-jdk
Copy link
Member

I'm unsure it belongs in hotspot-runtime

@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287927: ProblemList java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on macosx-aarch64

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8e07839: 8285081: Improve XPath operators count accuracy
  • b12e7f1: 8279358: vmTestbase/nsk/jvmti/scenarios/jni_interception/JI03/ji03t003/TestDescription.java fails with usage tracker

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@dcubed-ojdk
Copy link
Member Author

It doesn't belong in hotspot-runtime, but I include hotspot-runtime just in
case one of my team is on-the-air and can give a quick review...

@aivanov-jdk thanks for your review.

/integrate

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

Going to push as commit b7a34f7.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8e07839: 8285081: Improve XPath operators count accuracy
  • b12e7f1: 8279358: vmTestbase/nsk/jvmti/scenarios/jni_interception/JI03/ji03t003/TestDescription.java fails with usage tracker

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 7, 2022
@openjdk openjdk bot closed this Jun 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@dcubed-ojdk Pushed as commit b7a34f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8287927 branch June 7, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants