8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier #9077

satoyoshiki · 2022-06-08T04:59:07Z

Please review this PR.
SDK 10.15 and earlier reports os.version as 10.16 on Big Sur. This fix will check if dynamic linker support, which is supported from Big Sur, is available or not on the OS even if os.version is reported as 10.16 instead of 11. The os.version 10.16 doesn't include the update version like y of 10.x.y. Hence the change only see if it is 10.16 or not.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier

Reviewers

Mandy Chung (@mlchung - Reviewer) ⚠️ Review applies to a9b95965

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9077/head:pull/9077
$ git checkout pull/9077

Update a local copy of the PR:
$ git checkout pull/9077
$ git pull https://git.openjdk.org/jdk pull/9077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9077

View PR using the GUI difftool:
$ git pr show -t 9077

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9077.diff

…with macOS SDK 10.15 and earlier

bridgekeeper · 2022-06-08T05:00:42Z

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-06-08T05:02:48Z

@satoyoshiki The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-06-10T02:00:25Z

Webrevs

01: Full - Incremental (bdd97130)
00: Full (a9b95965)

mlchung

Looks good. Thanks for fixing this.

As a background, Big Sur reports 10.16 as backward compatibility when built with macOS SDK 10.15 and earlier. Hence this needs to check for os version 10.16 that supports dynamic linker cache.

mlchung · 2022-06-10T17:51:37Z

test/jdk/java/lang/RuntimeTests/loadLibrary/exeLibraryCache/LibraryFromCache.java

@@ -42,6 +42,8 @@

 public class LibraryFromCache {
    public static void main(String[] args) throws IOException {
+        System.out.println("os.version = " + System.getProperty("os.version"));


The copyright end year needs to be updated.

Thanks for catching.

openjdk · 2022-06-10T17:56:45Z

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 788 new commits pushed to the master branch:

bbaeacb: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
0f58097: 8288134: Super class names don't have envelopes
fb29770: 8287186: JDK modules participating in preview
0530f4e: 8288094: cleanup old _MSC_VER handling
1a65332: 8287906: Rewrite of GitHub Actions (GHA) sanity tests
c2ccf4c: 8288003: log events for os::dll_unload
03dca56: 8287525: Extend IR annotation with new options to test specific target feature.
86c9241: 8287028: AArch64: [vectorapi] Backend implementation of VectorMask.fromLong with SVE2
fbe9266: 8288378: [BACKOUT] DST not applying properly with zone id offset set with TZ env variable
1904353: Merge
... and 778 more: https://git.openjdk.org/jdk/compare/d84b9c54893dd33686d49755fca7a4b7f6a681c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

satoyoshiki · 2022-06-13T01:55:08Z

/integrate

openjdk · 2022-06-13T01:56:37Z

@satoyoshiki
Your change (at version a9b9596) is now ready to be sponsored by a Committer.

mlchung · 2022-06-14T16:15:06Z

/sponsor

openjdk · 2022-06-14T16:15:46Z

@mlchung The PR has been updated since the change author (@satoyoshiki) issued the integrate command - the author must perform this command again.

satoyoshiki · 2022-06-15T00:09:10Z

/integrate

openjdk · 2022-06-15T00:10:26Z

@satoyoshiki
Your change (at version bdd9713) is now ready to be sponsored by a Committer.

mlchung · 2022-06-15T00:10:38Z

/sponsor

openjdk · 2022-06-15T00:13:04Z

Going to push as commit fe80721.
Since your change was applied there have been 788 commits pushed to the master branch:

bbaeacb: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
0f58097: 8288134: Super class names don't have envelopes
fb29770: 8287186: JDK modules participating in preview
0530f4e: 8288094: cleanup old _MSC_VER handling
1a65332: 8287906: Rewrite of GitHub Actions (GHA) sanity tests
c2ccf4c: 8288003: log events for os::dll_unload
03dca56: 8287525: Extend IR annotation with new options to test specific target feature.
86c9241: 8287028: AArch64: [vectorapi] Backend implementation of VectorMask.fromLong with SVE2
fbe9266: 8288378: [BACKOUT] DST not applying properly with zone id offset set with TZ env variable
1904353: Merge
... and 778 more: https://git.openjdk.org/jdk/compare/d84b9c54893dd33686d49755fca7a4b7f6a681c4...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-06-15T00:13:18Z

@mlchung @satoyoshiki Pushed as commit fe80721.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8287917: System.loadLibrary does not work on Big Sur if JDK is built …

0c76d5e

…with macOS SDK 10.15 and earlier

openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 8, 2022

satoyoshiki added 3 commits June 9, 2022 14:34

Print os.version for logging purpose

41b208d

Move print-debug to the top

d20d896

Remove trailing whtiespace

a9b9596

satoyoshiki marked this pull request as ready for review June 10, 2022 01:54

openjdk bot added the rfr Pull request is ready for review label Jun 10, 2022

mlchung approved these changes Jun 10, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 10, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 13, 2022

openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Jun 13, 2022

Update copyright end year

bdd9713

openjdk bot removed the sponsor Pull request is ready to be sponsored label Jun 14, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 15, 2022

openjdk bot added the integrated Pull request has been integrated label Jun 15, 2022

openjdk bot closed this Jun 15, 2022

openjdk bot removed the ready Pull request is ready to be integrated label Jun 15, 2022

openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 15, 2022

8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier #9077

8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier #9077

satoyoshiki commented Jun 8, 2022 •

edited by openjdk bot

bridgekeeper bot commented Jun 8, 2022

openjdk bot commented Jun 8, 2022

mlbridge bot commented Jun 10, 2022 •

edited

mlchung left a comment

mlchung Jun 10, 2022

satoyoshiki Jun 14, 2022

openjdk bot commented Jun 10, 2022 •

edited

satoyoshiki commented Jun 13, 2022

openjdk bot commented Jun 13, 2022

mlchung commented Jun 14, 2022

openjdk bot commented Jun 14, 2022

satoyoshiki commented Jun 15, 2022

openjdk bot commented Jun 15, 2022

mlchung commented Jun 15, 2022

openjdk bot commented Jun 15, 2022

openjdk bot commented Jun 15, 2022

8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier #9077

8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier #9077

Conversation

satoyoshiki commented Jun 8, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jun 8, 2022

openjdk bot commented Jun 8, 2022

mlbridge bot commented Jun 10, 2022 • edited

Webrevs

mlchung left a comment

Choose a reason for hiding this comment

mlchung Jun 10, 2022

Choose a reason for hiding this comment

satoyoshiki Jun 14, 2022

Choose a reason for hiding this comment

openjdk bot commented Jun 10, 2022 • edited

satoyoshiki commented Jun 13, 2022

openjdk bot commented Jun 13, 2022

mlchung commented Jun 14, 2022

openjdk bot commented Jun 14, 2022

satoyoshiki commented Jun 15, 2022

openjdk bot commented Jun 15, 2022

mlchung commented Jun 15, 2022

openjdk bot commented Jun 15, 2022

openjdk bot commented Jun 15, 2022

satoyoshiki commented Jun 8, 2022 •

edited by openjdk bot

mlbridge bot commented Jun 10, 2022 •

edited

openjdk bot commented Jun 10, 2022 •

edited