Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8224768: Test ActalisCA.java fails #9097

Closed
wants to merge 2 commits into from
Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Jun 9, 2022

Updated with new test artifacts from CA.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9097/head:pull/9097
$ git checkout pull/9097

Update a local copy of the PR:
$ git checkout pull/9097
$ git pull https://git.openjdk.org/jdk pull/9097/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9097

View PR using the GUI difftool:
$ git pr show -t 9097

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9097.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2022

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Jun 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8224768: Test ActalisCA.java fails

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 186 new commits pushed to the master branch:

  • aaa8971: 8288227: Refactor annotation implementation to use pattern matching for instanceof
  • 2cc40af: 8287835: Add support for additional float/double to integral conversion for x86
  • 3ee1e60: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 512db0f: 8271838: AmazonCA.java interop test fails
  • fcb35ed: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed
  • bdd64d6: 8288181: AArch64: clean up out-of-date comments
  • 5d0e8b6: 8288203: runtime/ClassUnload/UnloadTestWithVerifyDuringGC.java fails with release VMs
  • 975316e: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
  • 0901548: 8283724: Incorrect description for jtreg-failure-handler option
  • dae4c49: 8286197: C2: Optimize MemorySegment shape in int loop
  • ... and 176 more: https://git.openjdk.org/jdk/compare/e0382c552348d108e906792ad8ca7067f9f805ec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 10, 2022
@rhalade
Copy link
Member Author

rhalade commented Jun 10, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

Going to push as commit c6dd2ab.
Since your change was applied there have been 186 commits pushed to the master branch:

  • aaa8971: 8288227: Refactor annotation implementation to use pattern matching for instanceof
  • 2cc40af: 8287835: Add support for additional float/double to integral conversion for x86
  • 3ee1e60: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 512db0f: 8271838: AmazonCA.java interop test fails
  • fcb35ed: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed
  • bdd64d6: 8288181: AArch64: clean up out-of-date comments
  • 5d0e8b6: 8288203: runtime/ClassUnload/UnloadTestWithVerifyDuringGC.java fails with release VMs
  • 975316e: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
  • 0901548: 8283724: Incorrect description for jtreg-failure-handler option
  • dae4c49: 8286197: C2: Optimize MemorySegment shape in int loop
  • ... and 176 more: https://git.openjdk.org/jdk/compare/e0382c552348d108e906792ad8ca7067f9f805ec...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jun 10, 2022
@openjdk openjdk bot closed this Jun 10, 2022
@openjdk openjdk bot removed ready rfr labels Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@rhalade Pushed as commit c6dd2ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8224768 branch Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants