Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 #9115

Closed
wants to merge 2 commits into from
Closed

8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 #9115

wants to merge 2 commits into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Jun 9, 2022 •
edited by openjdk bot
Loading

Add comment to the method.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9115/head:pull/9115
$ git checkout pull/9115

Update a local copy of the PR:
$ git checkout pull/9115
$ git pull https://git.openjdk.org/jdk pull/9115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9115

View PR using the GUI difftool:
$ git pr show -t 9115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9115.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2022

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2022 •
edited
Loading

Webrevs

jnimeh
jnimeh reviewed Jun 9, 2022
View reviewed changes
src/java.base/share/classes/sun/security/util/math/IntegerModuloP.java Outdated
@@ -156,6 +156,13 @@ default byte[] asByteArray(int len) {
* @return the multiplicative inverse (1 / this)
*/
default ImmutableIntegerModuloP multiplicativeInverse() {
// This method is used in 2 cases:
// 1. To calculate the inverse of a number in ECDSAOperations,
// this number must be non zero (modulus p).
Copy link
Member

@jnimeh jnimeh Jun 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be "modulo p"? Other than that it looks good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a verb here.

jnimeh
jnimeh approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@jnimeh jnimeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0

Reviewed-by: jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 187 new commits pushed to the master branch:

  • 900d967: 8287924: Avoid redundant HashMap.containsKey call in EnvHelp.mapToHashtable
  • d482d7f: 8286160: (fs) Files.exists returns unexpected results with C:\pagefile.sys because it's not readable
  • edff51e: 8284858: Start of release updates for JDK 20
  • 2671443: 8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100
  • 59b0de6: 8288048: Build failure with GCC 6 after JDK-8286562
  • db4405d: 8288078: linux-aarch64-optimized build fails in Tier5 after JDK-8287567
  • 7e948f7: 8287903: Reduce runtime of java.math microbenchmarks
  • 3fa9984: 8287854: Dangling reference in ClassVerifier::verify_class
  • 4285e3d: 8288023: AArch64: disable PAC-RET when preview is enabled
  • 560e292: 8287738: [PPC64] jdk/incubator/vector/*VectorTests failing
  • ... and 177 more: https://git.openjdk.org/jdk/compare/0c420e03ae24144a8146edb39f546841da33e381...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 9, 2022
@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

Going to push as commit d4b473d.
Since your change was applied there have been 206 commits pushed to the master branch:

  • da2339c: 8288173: JDK-8202449 fix causes conformance test failure : api/java_util/Random/RandomGenerator/NextFloat.html
  • f2e10dc: 8288238: Add missing file jdk.incubator.concurrent-J.sym.txt
  • fa564e9: Merge
  • 0164145: 8288222: ProblemList serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java
  • 03276a5: 8281445: Document the default value for the override-methods option
  • d0c8ff8: 8288195: Prepare build system for GHA changes
  • 7e940ef: 8286038: Update --release 19 symbol information for JDK 19 build 26
  • c6dd2ab: 8224768: Test ActalisCA.java fails
  • aaa8971: 8288227: Refactor annotation implementation to use pattern matching for instanceof
  • 2cc40af: 8287835: Add support for additional float/double to integral conversion for x86
  • ... and 196 more: https://git.openjdk.org/jdk/compare/0c420e03ae24144a8146edb39f546841da33e381...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 10, 2022
@openjdk openjdk bot closed this Jun 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@wangweij Pushed as commit d4b473d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8287178 branch June 11, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnimeh jnimeh jnimeh approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangweij @jnimeh