Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!" #9116

Closed
wants to merge 19 commits into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Jun 10, 2022

Bug history - #7422.
The test is automatic and check if the last row is painted (Which was not happening before the fix, the last row appeared only after MouseClick operation) by capturing the last row before and after MouseClick Operation.If the both the captured images are same, then the test passes else it fails.
This Fix includes for ubuntu and macos failure, in which only the test case failed due to following reasons.

  1. In ubuntu, the test fails due to unexpected dark line appearing on right side of last row before MouseClick operation.
  2. In macos, the test fails since after MouseClick operation of last row, clearSelection didn't show any effect on the selected row.
    The issue is intermittent and not able to reproduce it frequently. As a defensive fix, the rectangular area which is being captured is reduce for ubuntu failure and Delay is added between ClearSelection of focus and Image Capture for macos failure.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9116/head:pull/9116
$ git checkout pull/9116

Update a local copy of the PR:
$ git checkout pull/9116
$ git pull https://git.openjdk.org/jdk pull/9116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9116

View PR using the GUI difftool:
$ git pr show -t 9116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9116.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2022

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@TejeshR13 TejeshR13 closed this Jun 10, 2022
@TejeshR13 TejeshR13 deleted the branch_8284619 branch June 10, 2022 05:19
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

⚠️ @TejeshR13 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
1 participant