Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283612: IGV: Remove Graal module #9119

Closed
wants to merge 1 commit into from

Conversation

jyukutyo
Copy link
Contributor

@jyukutyo jyukutyo commented Jun 10, 2022

This pull request removes Graal module in Ideal Graph Visualizer. I think you might know that Graal JIT compiler was removed from OpenJDK in version 17. So IGV doesn't need to support Graal's dump files any more. It is noted that GraalVM has its own version of IGV (https://www.graalvm.org/22.1/tools/igv/).

It seems that there are no test cases related to Graal module. I've built IGV, run it and opened the graphs. Those were all successful.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9119/head:pull/9119
$ git checkout pull/9119

Update a local copy of the PR:
$ git checkout pull/9119
$ git pull https://git.openjdk.org/jdk pull/9119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9119

View PR using the GUI difftool:
$ git pr show -t 9119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9119.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2022

👋 Welcome back ksakata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@jyukutyo The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2022

Webrevs

Copy link
Contributor

@robcasloz robcasloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for this and your previous contributions to IGV, Koichi.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@jyukutyo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283612: IGV: Remove Graal module

Reviewed-by: rcastanedalo, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 94b473e: 8280454: G1: ClassLoaderData verification keeps CLDs live that causes problems with VerifyDuringGC during Remark
  • 900d967: 8287924: Avoid redundant HashMap.containsKey call in EnvHelp.mapToHashtable
  • d482d7f: 8286160: (fs) Files.exists returns unexpected results with C:\pagefile.sys because it's not readable
  • edff51e: 8284858: Start of release updates for JDK 20
  • 2671443: 8286171: HttpClient/2 : Expect:100-Continue blocks indefinitely when response is not 100
  • 59b0de6: 8288048: Build failure with GCC 6 after JDK-8286562
  • db4405d: 8288078: linux-aarch64-optimized build fails in Tier5 after JDK-8287567
  • 7e948f7: 8287903: Reduce runtime of java.math microbenchmarks
  • 3fa9984: 8287854: Dangling reference in ClassVerifier::verify_class
  • 4285e3d: 8288023: AArch64: disable PAC-RET when preview is enabled
  • ... and 1 more: https://git.openjdk.org/jdk/compare/e5b56bafa9ed68dec82adebc3eb298b70df7faeb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 10, 2022
@jyukutyo
Copy link
Contributor Author

Thank you for the reviews, Roberto and Christian!

@jyukutyo
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@jyukutyo
Your change (at version 5acbbb4) is now ready to be sponsored by a Committer.

@robcasloz
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 13, 2022

Going to push as commit ac28be7.
Since your change was applied there have been 34 commits pushed to the master branch:

  • 0cb0ecf: 8209935: Test to cover CodeSource.getCodeSigners()
  • f1143b1: 8287696: Avoid redundant Hashtable.containsKey call in JarVerifier.doneWithMeta
  • d46f404: 8279047: Remove expired flags in JDK 20
  • f7a4be7: 8288270: Tier1 build failures after JDK-8287178
  • d4b473d: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0
  • da2339c: 8288173: JDK-8202449 fix causes conformance test failure : api/java_util/Random/RandomGenerator/NextFloat.html
  • f2e10dc: 8288238: Add missing file jdk.incubator.concurrent-J.sym.txt
  • fa564e9: Merge
  • 0164145: 8288222: ProblemList serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java
  • 03276a5: 8281445: Document the default value for the override-methods option
  • ... and 24 more: https://git.openjdk.org/jdk/compare/e5b56bafa9ed68dec82adebc3eb298b70df7faeb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2022
@openjdk openjdk bot closed this Jun 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 13, 2022
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

@robcasloz @jyukutyo Pushed as commit ac28be7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jyukutyo
Copy link
Contributor Author

Thank you for sponsoring, Roberto!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants