8288173: JDK-8202449 fix causes conformance test failure : api/java_util/Random/RandomGenerator/NextFloat.html

[rgiulietti]

This fixes a bug introduced with JDK-8202449.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288173: JDK-8202449 fix causes conformance test failure : api/java_util/Random/RandomGenerator/NextFloat.html

Reviewers

• Brian Burkhalter (@bplb - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9120/head:pull/9120
$ git checkout pull/9120

Update a local copy of the PR:
$ git checkout pull/9120
$ git pull https://git.openjdk.org/jdk pull/9120/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9120

View PR using the GUI difftool:
$ git pr show -t 9120

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9120.diff

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (869da8c9)

[rgiulietti]

/backport jdk19

[openjdk]

@rgiulietti Unknown command backport - for a list of valid commands use /help.

[rgiulietti]

/help

[openjdk]

@rgiulietti Available commands:

• cc - add or remove an additional classification label
• clean - Mark the backport pull request as a clean backport
• contributor - adds or removes additional contributors for a PR
• covered - used when employer has signed the OCA
• csr - require a compatibility and specification request (CSR) for this pull request
• help - shows this text
• integrate - performs integration of the changes in the PR
• issue - edit the list of issues that this PR solves
• jep - require a JDK Enhancement Proposal (JEP) for this pull request
• label - add or remove an additional classification label
• open - Set the pull request state to "open"
• reviewer - manage additional reviewers for a PR
• reviewers - set the number of additional required reviewers for this PR
• signed - used after signing the OCA
• solves - edit the list of issues that this PR solves
• sponsor - performs integration of a PR that is authored by a non-committer
• summary - updates the summary in the commit message
• test - used to run tests

[rgiulietti]

The fix reverts an inadvertent "correction" sneaked into JDK-8202449, restoring previous (correct) behavior.

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288173: JDK-8202449 fix causes conformance test failure : api/java_util/Random/RandomGenerator/NextFloat.html

Reviewed-by: bpb, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• f2e10dc: 8288238: Add missing file jdk.incubator.concurrent-J.sym.txt
• fa564e9: Merge
• 0164145: 8288222: ProblemList serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java
• 03276a5: 8281445: Document the default value for the override-methods option
• d0c8ff8: 8288195: Prepare build system for GHA changes
• 7e940ef: 8286038: Update --release 19 symbol information for JDK 19 build 26
• c6dd2ab: 8224768: Test ActalisCA.java fails
• aaa8971: 8288227: Refactor annotation implementation to use pattern matching for instanceof
• 2cc40af: 8287835: Add support for additional float/double to integral conversion for x86
• 3ee1e60: 8288132: Update test artifacts in QuoVadis CA interop tests
• ... and 7 more: https://git.openjdk.org/jdk/compare/94b473e4642a5a4626faeb73341b4aea128ccb31...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb, @jddarcy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[rgiulietti]

/integrate

[openjdk]

@rgiulietti
Your change (at version 869da8c) is now ready to be sponsored by a Committer.

[jddarcy]

Changes look okay, but please do a follow-up fix to add some regression tests for this condition.

[bplb]

/sponsor

[openjdk]

Going to push as commit da2339c.
Since your change was applied there have been 17 commits pushed to the master branch:

• f2e10dc: 8288238: Add missing file jdk.incubator.concurrent-J.sym.txt
• fa564e9: Merge
• 0164145: 8288222: ProblemList serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java
• 03276a5: 8281445: Document the default value for the override-methods option
• d0c8ff8: 8288195: Prepare build system for GHA changes
• 7e940ef: 8286038: Update --release 19 symbol information for JDK 19 build 26
• c6dd2ab: 8224768: Test ActalisCA.java fails
• aaa8971: 8288227: Refactor annotation implementation to use pattern matching for instanceof
• 2cc40af: 8287835: Add support for additional float/double to integral conversion for x86
• 3ee1e60: 8288132: Update test artifacts in QuoVadis CA interop tests
• ... and 7 more: https://git.openjdk.org/jdk/compare/94b473e4642a5a4626faeb73341b4aea128ccb31...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb @rgiulietti Pushed as commit da2339c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.