Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288114: Update JIRA link in vcs.xml #9130

Closed
wants to merge 1 commit into from

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Jun 10, 2022

Update the link to JBS in vcs.xml template to https://bugs.openjdk.org/

It will affect newly generated project files only.
Edit vcs.xml manually or in UI to update in existing projects.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288114: Update JIRA link in vcs.xml ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9130/head:pull/9130
$ git checkout pull/9130

Update a local copy of the PR:
$ git checkout pull/9130
$ git pull https://git.openjdk.org/jdk pull/9130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9130

View PR using the GUI difftool:
$ git pr show -t 9130

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9130.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2022

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@aivanov-jdk The following labels will be automatically applied to this pull request:

  • build
  • ide-support

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org ide-support ide-support-dev@openjdk.org labels Jun 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2022

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288114: Update JIRA link in vcs.xml

Reviewed-by: mcimadamore, ihse, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 0207d76: 8287926: AArch64: intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long
  • 33ed036: 8283775: better dump: VM support for graph querying in debugger with BFS traversal and node filtering
  • ac28be7: 8283612: IGV: Remove Graal module
  • 0cb0ecf: 8209935: Test to cover CodeSource.getCodeSigners()
  • f1143b1: 8287696: Avoid redundant Hashtable.containsKey call in JarVerifier.doneWithMeta
  • d46f404: 8279047: Remove expired flags in JDK 20
  • f7a4be7: 8288270: Tier1 build failures after JDK-8287178
  • d4b473d: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0
  • da2339c: 8288173: JDK-8202449 fix causes conformance test failure : api/java_util/Random/RandomGenerator/NextFloat.html
  • f2e10dc: 8288238: Add missing file jdk.incubator.concurrent-J.sym.txt
  • ... and 8 more: https://git.openjdk.org/jdk/compare/3ee1e60595171be0dd8bda47d96e0a1268cdc461...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 10, 2022
@aivanov-jdk
Copy link
Member Author

/itegrate

@aivanov-jdk
Copy link
Member Author

Bot, wake up! Will it help?

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Jun 13, 2022
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

@aivanov-jdk Unknown command itegrate - for a list of valid commands use /help.

@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2022

Going to push as commit b97a4f6.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 2adef6a: 8267860: Off-by-one bug when searching arrays in AlpnGreaseTest
  • 4aede33: 8288282: Zero-release build is broken after JDK-8279047 due to UseHeavyMonitors is read-only
  • 0207d76: 8287926: AArch64: intrinsics for divideUnsigned and remainderUnsigned methods in java.lang.Integer and java.lang.Long
  • 33ed036: 8283775: better dump: VM support for graph querying in debugger with BFS traversal and node filtering
  • ac28be7: 8283612: IGV: Remove Graal module
  • 0cb0ecf: 8209935: Test to cover CodeSource.getCodeSigners()
  • f1143b1: 8287696: Avoid redundant Hashtable.containsKey call in JarVerifier.doneWithMeta
  • d46f404: 8279047: Remove expired flags in JDK 20
  • f7a4be7: 8288270: Tier1 build failures after JDK-8287178
  • d4b473d: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0
  • ... and 10 more: https://git.openjdk.org/jdk/compare/3ee1e60595171be0dd8bda47d96e0a1268cdc461...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2022
@openjdk openjdk bot closed this Jun 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2022
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

@aivanov-jdk Pushed as commit b97a4f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8288114-vcs.xml branch September 14, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org ide-support ide-support-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants