Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8288238: Add missing file jdk.incubator.concurrent-J.sym.txt #9133

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Jun 10, 2022

The fix for JDK-8286038 accidentally omitted one of the new files.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288238: Add missing file jdk.incubator.concurrent-J.sym.txt

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9133/head:pull/9133
$ git checkout pull/9133

Update a local copy of the PR:
$ git checkout pull/9133
$ git pull https://git.openjdk.org/jdk pull/9133/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9133

View PR using the GUI difftool:
$ git pr show -t 9133

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9133.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jun 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2022

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is an urgent build fix.

@jddarcy
Copy link
Member Author

jddarcy commented Jun 10, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288238: Add missing file jdk.incubator.concurrent-J.sym.txt

Reviewed-by: mikael, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fa564e9: Merge
  • 0164145: 8288222: ProblemList serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java
  • 03276a5: 8281445: Document the default value for the override-methods option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

Going to push as commit f2e10dc.
Since your change was applied there have been 3 commits pushed to the master branch:

  • fa564e9: Merge
  • 0164145: 8288222: ProblemList serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java
  • 03276a5: 8281445: Document the default value for the override-methods option

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 10, 2022
@openjdk openjdk bot closed this Jun 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@jddarcy Pushed as commit f2e10dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants