-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8288270: Tier1 build failures after JDK-8287178 #9135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back hchao! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
Thanks.
/integrate |
@haimaychao This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@DamonFool @wangweij Thanks for the review! |
Going to push as commit f7a4be7. |
@haimaychao Pushed as commit f7a4be7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@haimaychao The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Please review the small fix in comment.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9135/head:pull/9135
$ git checkout pull/9135
Update a local copy of the PR:
$ git checkout pull/9135
$ git pull https://git.openjdk.org/jdk pull/9135/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9135
View PR using the GUI difftool:
$ git pr show -t 9135
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9135.diff