Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288468: Avoid redundant HashMap.get call in NegotiateAuthentication.firstToken #9145

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Jun 13, 2022

Instead of separate HashMap.get+remove call, we can use single HashMap.remove call and use its return value.

HashMap <String, Negotiator> cachedMap = getCache();
if (cachedMap != null) {
negotiator = cachedMap.get(getHost());
if (negotiator != null) {
cachedMap.remove(getHost()); // so that it is only used once
}
}

It makes code a bit cleaner and faster.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288468: Avoid redundant HashMap.get call in NegotiateAuthentication.firstToken

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9145/head:pull/9145
$ git checkout pull/9145

Update a local copy of the PR:
$ git checkout pull/9145
$ git pull https://git.openjdk.org/jdk pull/9145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9145

View PR using the GUI difftool:
$ git pr show -t 9145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9145.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 13, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jun 13, 2022
@turbanoff turbanoff changed the title [PATCH] Avoid redundant HashMap.get call in NegotiateAuthentication.firstToken 8288468: Avoid redundant HashMap.get call in NegotiateAuthentication.firstToken Jun 15, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 15, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2022

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please make sure to run tier2 tests before integrating.

@openjdk
Copy link

openjdk bot commented Jun 15, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288468: Avoid redundant HashMap.get call in NegotiateAuthentication.firstToken

Reviewed-by: dfuchs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • d5cd2f2: 8284849: Add deoptimization to unified logging
  • dfeeb6f: 8288140: Avoid redundant Hashtable.get call in Signal.handle
  • 68b2057: 8287373: remove unnecessary paddings in generated code
  • 2471f8f: 8287647: VM debug support: find node by pattern in name or dump
  • 33f34d5: 8288207: Enhance MalformedURLException in Uri.parseCompat
  • 444a0d9: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist
  • 08400f1: 8287349: AArch64: Merge LDR instructions to improve C1 OSR performance
  • fe80721: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
  • bbaeacb: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
  • 0f58097: 8288134: Super class names don't have envelopes
  • ... and 15 more: https://git.openjdk.org/jdk/compare/53a0acee06eb32fba700967c9a34d37ea42f7a99...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2022
@turbanoff
Copy link
Member Author

Tests are fine.
/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2022

Going to push as commit ce5024f.
Since your change was applied there have been 50 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2022
@openjdk openjdk bot closed this Jun 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2022
@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@turbanoff Pushed as commit ce5024f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the avoid_redundant_HashMap.containsKey_in_NegotiateAuthentication branch October 27, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
3 participants