JDK-8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist

[MBaesken]

When running test/jdk/jdk/internal/platform/cgroup/TestCgroupMetrics.java on ubuntu 21.10 or 22 , this test looks for a named value "nr_periods" in the file /sys/fs/cgroup/..../cpu.stat . However this metric is not always present, which leads to an AIOOB exception.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9153/head:pull/9153
$ git checkout pull/9153

Update a local copy of the PR:
$ git checkout pull/9153
$ git pull https://git.openjdk.org/jdk pull/9153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9153

View PR using the GUI difftool:
$ git pr show -t 9153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9153.diff

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1a4afbb4)

[jerboaa]

LGTM

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist

Reviewed-by: sgehwolf, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 0f58097: 8288134: Super class names don't have envelopes
• fb29770: 8287186: JDK modules participating in preview

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

Do we want to fix it in JDK20 only (not 19)? "Bugs of any priority whose fixes only affect tests, or test-problem lists, or documentation may be fixed in RDP 1 and RDP 2." https://openjdk.org/jeps/3#rdp-1

[MBaesken]

/integrate

[MBaesken]

Do we want to fix it in JDK20 only (not 19)? "Bugs of any priority whose fixes only affect tests, or test-problem lists, or documentation may be fixed in RDP 1 and RDP 2." https://openjdk.org/jeps/3#rdp-1

I think we can backport it if needed.

[openjdk]

Going to push as commit 444a0d9.
Since your change was applied there have been 5 commits pushed to the master branch:

• 08400f1: 8287349: AArch64: Merge LDR instructions to improve C1 OSR performance
• fe80721: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
• bbaeacb: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
• 0f58097: 8288134: Super class names don't have envelopes
• fb29770: 8287186: JDK modules participating in preview

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 444a0d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.