8288399: MacOS debug symbol files not always deterministic in reproducible builds

[andrew-m-leonard]

MacOS builds built with ENABLE_REPRODUCIBLE_BUILD enabled still contain full build paths in the
debug symbol information. Linux gcc reproducible builds already uses -fdebug-prefix-map to make these deterministic,
clang supports the same option, and testing with this for clang shows correct mapping.
Similiarly for reproducible builds assembly source file debug declarations need to be relative, as is for Linux gcc.

The compiler generated unique function symbols contain a random generated part, which if not deterministically
seeded will be random. -frandom-seed provides a deterministic seed solution.

Signed-off-by: Andrew Leonard anleonar@redhat.com

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288399: MacOS debug symbol files not always deterministic in reproducible builds

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9166/head:pull/9166
$ git checkout pull/9166

Update a local copy of the PR:
$ git checkout pull/9166
$ git pull https://git.openjdk.org/jdk pull/9166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9166

View PR using the GUI difftool:
$ git pr show -t 9166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9166.diff

[bridgekeeper]

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andrew-m-leonard The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3947d3bf)

[openjdk]

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288399: MacOS debug symbol files not always deterministic in reproducible builds

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• dfeeb6f: 8288140: Avoid redundant Hashtable.get call in Signal.handle
• 68b2057: 8287373: remove unnecessary paddings in generated code
• 2471f8f: 8287647: VM debug support: find node by pattern in name or dump
• 33f34d5: 8288207: Enhance MalformedURLException in Uri.parseCompat
• 444a0d9: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist
• 08400f1: 8287349: AArch64: Merge LDR instructions to improve C1 OSR performance
• fe80721: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
• bbaeacb: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
• 0f58097: 8288134: Super class names don't have envelopes
• fb29770: 8287186: JDK modules participating in preview
• ... and 1 more: https://git.openjdk.org/jdk/compare/1a6533225d8f4b9c5d21e236eaa9f827f096fa5d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andrew-m-leonard]

thanks @erikj79

[andrew-m-leonard]

/integrate

[openjdk]

Going to push as commit 6633855.
Since your change was applied there have been 12 commits pushed to the master branch:

• d5cd2f2: 8284849: Add deoptimization to unified logging
• dfeeb6f: 8288140: Avoid redundant Hashtable.get call in Signal.handle
• 68b2057: 8287373: remove unnecessary paddings in generated code
• 2471f8f: 8287647: VM debug support: find node by pattern in name or dump
• 33f34d5: 8288207: Enhance MalformedURLException in Uri.parseCompat
• 444a0d9: 8284977: MetricsTesterCgroupV2.getLongValueEntryFromFile fails when named value doesn't exist
• 08400f1: 8287349: AArch64: Merge LDR instructions to improve C1 OSR performance
• fe80721: 8287917: System.loadLibrary does not work on Big Sur if JDK is built with macOS SDK 10.15 and earlier
• bbaeacb: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
• 0f58097: 8288134: Super class names don't have envelopes
• ... and 2 more: https://git.openjdk.org/jdk/compare/1a6533225d8f4b9c5d21e236eaa9f827f096fa5d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@andrew-m-leonard Pushed as commit 6633855.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.