8288480: IGV: toolbar action is not applied to the focused graph

[robcasloz]

When multiple graphs are displayed simultaneously in split windows, the following toolbar actions are always applied to the same graph, regardless of which graph window is focused:

• search nodes and blocks
• extract node
• hide node
• show all nodes
• zoom in
• zoom out

This changeset ensures that each of the above actions is only applied within its corresponding graph window. This is achieved by applying the actions to the graph window that is currently activated (EditorTopComponent.getRegistry().getActivated()) instead of the first matching occurrence in WindowManager.getDefault().getModes().

The changeset makes it practical, for example, to explore different views of the same graph simultaneously, as illustrated here:

Tested manually by triggering the above actions within multiple split graph windows and asserting that they are only applied to their corresponding graphs.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288480: IGV: toolbar action is not applied to the focused graph

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9169/head:pull/9169
$ git checkout pull/9169

Update a local copy of the PR:
$ git checkout pull/9169
$ git pull https://git.openjdk.org/jdk pull/9169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9169

View PR using the GUI difftool:
$ git pr show -t 9169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9169.diff

[bridgekeeper]

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robcasloz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0d6fe2f2)

[chhagedorn]

I've also ran into this problem before, thanks for fixing this! Looks good!

[openjdk]

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288480: IGV: toolbar action is not applied to the focused graph

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• 47b8669: 8288573: Make Executable.getParameterCount() actually abstract
• af64d31: Merge
• 53bf1bf: 8286176: Add JNI_VERSION_19 to jni.h and JNI spec
• c254c9d: 8287401: jpackage tests failing on Windows due to powershell issue
• ff3db52: 8288534: Out of bound errors for memory segment access mentions wrong values
• cc44592: 8287904: Reduce runtime of java.net microbenchmarks
• 523d553: 8282777: Create a Regression test for JDK-4515031
• f3da7ff: 8288421: IGV: warn user about all unreachable nodes
• 9d4b25e: 8288281: compiler/vectorapi/VectorFPtoIntCastTest.java failed with "IRViolationException: There were one or multiple IR rule failures."
• e833c1d: 8285519: Change usages of TimeUnit.convert to TimeUnit.toXXX
• ... and 28 more: https://git.openjdk.org/jdk/compare/d5cd2f2caa857891c2cbc13e7da4f85720f3bbb7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[robcasloz]

I've also ran into this problem before, thanks for fixing this! Looks good!

Thanks for reviewing, Christian!

[TobiHartmann]

Looks good.

[robcasloz]

Looks good.

Thanks, Tobias!

[robcasloz]

/integrate

[openjdk]

Going to push as commit f62b2bd.
Since your change was applied there have been 40 commits pushed to the master branch:

• 02da5f9: 8263384: IGV: Outline should highlight the Graph that has focus
• 7d4df6a: 8284404: Too aggressive sweeping with Loom
• 47b8669: 8288573: Make Executable.getParameterCount() actually abstract
• af64d31: Merge
• 53bf1bf: 8286176: Add JNI_VERSION_19 to jni.h and JNI spec
• c254c9d: 8287401: jpackage tests failing on Windows due to powershell issue
• ff3db52: 8288534: Out of bound errors for memory segment access mentions wrong values
• cc44592: 8287904: Reduce runtime of java.net microbenchmarks
• 523d553: 8282777: Create a Regression test for JDK-4515031
• f3da7ff: 8288421: IGV: warn user about all unreachable nodes
• ... and 30 more: https://git.openjdk.org/jdk/compare/d5cd2f2caa857891c2cbc13e7da4f85720f3bbb7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robcasloz Pushed as commit f62b2bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.