8288281: compiler/vectorapi/VectorFPtoIntCastTest.java failed with "IRViolationException: There were one or multiple IR rule failures."

[sviswa7]

The IR Framework test was failing due to incorrect node name.
Corrected the IR node name check.

Please review.

Best Regards,
Sandhya

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288281: compiler/vectorapi/VectorFPtoIntCastTest.java failed with "IRViolationException: There were one or multiple IR rule failures."

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer) ⚠️ Review applies to 5baf4623

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9177/head:pull/9177
$ git checkout pull/9177

Update a local copy of the PR:
$ git checkout pull/9177
$ git pull https://git.openjdk.org/jdk pull/9177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9177

View PR using the GUI difftool:
$ git pr show -t 9177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9177.diff

[bridgekeeper]

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sviswa7 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e8028014)
• 00: Full (5baf4623)

[TobiHartmann]

Looks good and trivial.

[openjdk]

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288281: compiler/vectorapi/VectorFPtoIntCastTest.java failed with "IRViolationException: There were one or multiple IR rule failures."

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 8fc8fdc: 8287905: Reduce runtime of java.nio microbenchmarks
• cf4a496: 8288064: Class initialization locking
• 3d12c02: Merge
• 729164f: 8288533: Missing @param tags in com.sun.source classes
• 9254e12: 8288526: ProblemList gc/stress/TestStressG1Humongous.java on windows-x64
• 395aea3: 8288414: Long::compress/expand samples are not correct
• f3b1f60: 8288289: Preview APIs in jdk.jdi, jdk.management, and jdk.jfr should be reflective preview APIs
• 31bc689: 8288324: Loom: Uninitialized JvmtiEnvs in VM_Virtual* ops
• 50f99c3: 8288360: CI: ciInstanceKlass::implementor() is not consistent for well-known classes
• 5a8e1e4: 8287889: (fs) Files.copy description of REPLACE_EXISTING is hard to read
• ... and 6 more: https://git.openjdk.org/jdk/compare/f7ba3b7e422c0a4b899b7aa11d0f903e6c1614a9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Otherwise, looks good!

[chhagedorn]

You can directly use IRNode.VECTOR_CAST_F2X (and IRNode.VECTOR_CAST_D2X below) which makes it clearer that this is an actual IR node and not a custom string.

[sviswa7]

@chhagedorn I made the change accordingly.

[sviswa7]

/integrate

[openjdk]

Going to push as commit 9d4b25e.
Since your change was applied there have been 20 commits pushed to the master branch:

• e833c1d: 8285519: Change usages of TimeUnit.convert to TimeUnit.toXXX
• e7d52e2: 8288594: Address possibly lossy conversions in java.base FloatToDecimal
• 2cf7c01: 8288478: AArch64: Clean up whitespace in assembler_aarch64.hpp
• ce5024f: 8288468: Avoid redundant HashMap.get call in NegotiateAuthentication.firstToken
• 8fc8fdc: 8287905: Reduce runtime of java.nio microbenchmarks
• cf4a496: 8288064: Class initialization locking
• 3d12c02: Merge
• 729164f: 8288533: Missing @param tags in com.sun.source classes
• 9254e12: 8288526: ProblemList gc/stress/TestStressG1Humongous.java on windows-x64
• 395aea3: 8288414: Long::compress/expand samples are not correct
• ... and 10 more: https://git.openjdk.org/jdk/compare/f7ba3b7e422c0a4b899b7aa11d0f903e6c1614a9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sviswa7 Pushed as commit 9d4b25e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.