8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark

[ghost]

Please review the improvements which I have made to the java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any further improvements are required.

Thanks,
Jason

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark

Reviewers

• Claes Redestad (@cl4es - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/918/head:pull/918
$ git checkout pull/918

[bridgekeeper]

👋 Welcome back jasontatton-aws! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jasontatton-aws The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0748535)
• 00: Full (5f3a1ce)

[cl4es]

Looks OK.

FWIW the current looping scheme look like what the SafeLooping.measureWrong_2 warns us about, and could possibly be improved by taking cues from SafeLooping.measureRight_1 and sink each what.indexOf(..) into a BlackHole. This might matter here since each unit of work is quite small.

I'll approve the patch as-is, but please consider making those changes.

[openjdk]

⚠️ @jasontatton-aws the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8254782
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@jasontatton-aws This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark

Reviewed-by: redestad, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• ea26ff1: 8247614: java/nio/channels/DatagramChannel/Connect.java timed out
• 38574d5: 8255298: Remove SurvivorAlignmentInBytes functionality
• 4031cb4: 8254189: Improve comments for StackOverFlow and fix in_xxx() functions
• caec8d2: 8233560: [TESTBUG] ToolTipManager/Test6256140.java is failing on macos
• a5b42ec: 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos
• 7e305ad: 8255405: sun/net/ftp/imp/FtpClient uses SimpleDateFormat in not thread-safe manner
• d82a6dc: 8255438: [Vector API] More instructs in x86.ad should use legacy mode for code-gen
• 1a5e6c9: 8253101: Clean up CallStaticJavaNode EA flags
• a7595b2: 8250669: Running JMH micros is broken after JDK-8248135
• edd1988: 8255530: Additional cleanup after JDK-8235710 (elliptic curve removal)
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/1215b1a8f573879f4dce0c1899935a638aa0e815...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@cl4es, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shipilev]

Looks fine to me, thanks.

[cl4es]

/test builds

[openjdk]

Could not create test job

[ghost]

/integrate

[openjdk]

@jasontatton-aws
Your change (at version 0748535) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

@shipilev @jasontatton-aws Since your change was applied there have been 14 commits pushed to the master branch:

• ea26ff1: 8247614: java/nio/channels/DatagramChannel/Connect.java timed out
• 38574d5: 8255298: Remove SurvivorAlignmentInBytes functionality
• 4031cb4: 8254189: Improve comments for StackOverFlow and fix in_xxx() functions
• caec8d2: 8233560: [TESTBUG] ToolTipManager/Test6256140.java is failing on macos
• a5b42ec: 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos
• 7e305ad: 8255405: sun/net/ftp/imp/FtpClient uses SimpleDateFormat in not thread-safe manner
• d82a6dc: 8255438: [Vector API] More instructs in x86.ad should use legacy mode for code-gen
• 1a5e6c9: 8253101: Clean up CallStaticJavaNode EA flags
• a7595b2: 8250669: Running JMH micros is broken after JDK-8248135
• edd1988: 8255530: Additional cleanup after JDK-8235710 (elliptic curve removal)
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/1215b1a8f573879f4dce0c1899935a638aa0e815...master

Your commit was automatically rebased without conflicts.

Pushed as commit 72ff8e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.