Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288568: Reduce runtime of java.security microbenchmarks #9189

Closed
wants to merge 3 commits into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Jun 16, 2022

  • Reduce forks, iteration, runtime to reduce runtime while maintaining high data quality on typical benchmarking hosts.

Reduces runtime from estimated 10+ hours to 54 minutes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288568: Reduce runtime of java.security microbenchmarks

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9189/head:pull/9189
$ git checkout pull/9189

Update a local copy of the PR:
$ git checkout pull/9189
$ git pull https://git.openjdk.org/jdk pull/9189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9189

View PR using the GUI difftool:
$ git pr show -t 9189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9189.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2022

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 16, 2022
@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@cl4es The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 16, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2022

Webrevs

Copy link

@ericcaspole ericcaspole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@haimaychao
Copy link
Contributor

Looks good. Would you also consider to apply the same value or iteration to PermissionsImplies.java and javax/crypto/Crypto.java? The copyright year for some of the Oracle files in this PR can be changed to 2022. Thanks!

@cl4es
Copy link
Member Author

cl4es commented Jun 17, 2022

Looks good. Would you also consider to apply the same value or iteration to PermissionsImplies.java and javax/crypto/Crypto.java? The copyright year for some of the Oracle files in this PR can be changed to 2022. Thanks!

Fixed copyrights and made PermissionImplies consistent.

I'm going through micros package-by-package and will deal with javax/crypto microbenchmarks in a follow-up.

@haimaychao
Copy link
Contributor

Sounds like a good plan. Thanks for the update.

@cl4es
Copy link
Member Author

cl4es commented Jun 20, 2022

Thanks for reviewing!

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2022

@cl4es This pull request has not yet been marked as ready for integration.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2022

@cl4es This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jul 18, 2022

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288568: Reduce runtime of java.security microbenchmarks

Reviewed-by: ecaspole, hchao, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 629 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2022
Comment on lines 54 to 56
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 5, time = 1)
@Fork(value = 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the @Warmup, @Measurement, and @Fork be removed from the doHandshake() benchmark on lines 115-117 below so that these take effect?

@Benchmark
@Warmup(iterations = 5, time = 5, timeUnit = TimeUnit.SECONDS)
@Measurement(iterations = 5, time = 5, timeUnit = TimeUnit.SECONDS)
@Fork(3)
public SSLSession doHandshake() throws Exception {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation. This means this benchmark was already tuned, and the pre-existing tuning overrides the setting I thought I was testing with. I've effectively reverted the changes but moved the annotations to class scope for consistency.

@cl4es
Copy link
Member Author

cl4es commented Aug 11, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 11, 2022

Going to push as commit a28ab7b.
Since your change was applied there have been 694 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 11, 2022
@openjdk openjdk bot closed this Aug 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 11, 2022
@openjdk
Copy link

openjdk bot commented Aug 11, 2022

@cl4es Pushed as commit a28ab7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
5 participants