8288601: Consolidate static/dynamic archive tables

[iklam]

Please review this small clean-up of almost identical code that handles the tables for the static and dynamic archives.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288601: Consolidate static/dynamic archive tables

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer) ⚠️ Review applies to 1d15341b
• @kristylee88 (no known github.com user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9190/head:pull/9190
$ git checkout pull/9190

Update a local copy of the PR:
$ git checkout pull/9190
$ git pull https://git.openjdk.org/jdk pull/9190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9190

View PR using the GUI difftool:
$ git pr show -t 9190

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9190.diff

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c2626245)
• 00: Full (1d15341b)

[calvinccheung]

Only a blank line was added.

[calvinccheung]

Nice cleanup.
Has this changeset gone through any tier(s) testing?

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288601: Consolidate static/dynamic archive tables

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 47b8669: 8288573: Make Executable.getParameterCount() actually abstract
• af64d31: Merge
• 53bf1bf: 8286176: Add JNI_VERSION_19 to jni.h and JNI spec
• c254c9d: 8287401: jpackage tests failing on Windows due to powershell issue
• ff3db52: 8288534: Out of bound errors for memory segment access mentions wrong values
• cc44592: 8287904: Reduce runtime of java.net microbenchmarks
• 523d553: 8282777: Create a Regression test for JDK-4515031
• f3da7ff: 8288421: IGV: warn user about all unreachable nodes
• 9d4b25e: 8288281: compiler/vectorapi/VectorFPtoIntCastTest.java failed with "IRViolationException: There were one or multiple IR rule failures."
• e833c1d: 8285519: Change usages of TimeUnit.convert to TimeUnit.toXXX
• ... and 20 more: https://git.openjdk.org/jdk/compare/07612281b084de62b6fb9e682184f93316130f41...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

Nice cleanup. Has this changeset gone through any tier(s) testing?

Hi Calvin,

Thanks for the review. This changeset has passed tiers 1-4. I also removed the blank line change you found.

[iklam]

/integrate

[openjdk]

Going to push as commit ad89146.
Since your change was applied there have been 54 commits pushed to the master branch:

• 7e211d7: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run
• 7039c66: Merge
• 453e8be: 8288527: broken link in java.base/java/util/zip/package-summary.html
• 33d0363: 8288741: JFR: Change package name of snippet files
• 0408f9c: 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state
• 1cf83a4: 8287800: JFR: Incorrect error message when starting recording with missing .jfc file
• 09da87c: 8288485: jni/nullCaller/NullCallerTest.java failing (ppc64)
• ed714af: 8288564: C2: LShiftLNode::Ideal produces wrong result after JDK-8278114
• ae030bc: 8288397: AArch64: Fix register issues in SVE backend match rules
• f12d044: 8288692: jdk/javadoc/doclet/testTagMisuse/TestTagMisuse.java fails after JDK-8288545
• ... and 44 more: https://git.openjdk.org/jdk/compare/07612281b084de62b6fb9e682184f93316130f41...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit ad89146.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.