Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288528: broken links in java.desktop #9195

Closed
wants to merge 3 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jun 17, 2022

doccheck reports some broken links which are rectified


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9195/head:pull/9195
$ git checkout pull/9195

Update a local copy of the PR:
$ git checkout pull/9195
$ git pull https://git.openjdk.org/jdk pull/9195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9195

View PR using the GUI difftool:
$ git pr show -t 9195

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9195.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2022
@openjdk
Copy link

openjdk bot commented Jun 17, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 17, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2022

Webrevs

<a href="https://bugs.java.com/view_bug.do?bug_id=4030718">
<a href="https://bugs.openjdk.org/browse/JDK-4030718">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old URL has changed to https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4030718

I am for using JBS links though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK 1.4 launched over 20 years ago. I think we can just scrap the link.
Maybe change the text to scrap mentioining it and just leave the text starting with

"AWT terminates all its helper threads allowing .. "

Comment on lines 2142 to 2143
* Returns a {@code LayoutStyle} implementing Java look and feel
* design guidelines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Returns a {@code LayoutStyle} implementing Java look and feel
* design guidelines.
* Returns a {@code LayoutStyle} implementing the Java look and feel
* design guidelines.

@openjdk
Copy link

openjdk bot commented Jun 17, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288528: broken links in java.desktop

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2022
@@ -39,7 +39,7 @@ <h1>Using the Multiplexing Look and Feel</h1>
<i>
This document is based on an article
originally published in
<a href="http://www.oracle.com/technetwork/java/javase/tech/articles-jsp-139072.html"
<a href="https://www.comp.nus.edu.sg/~cs3283/ftp/Java/swingConnect/archive/plaf_papers_arch/multi_update/multi_update.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I am 100% sure this article wasn't originally published by the national university of singapore.
And we definitely should NOT be linking there.
I actually think for most of these we'd be better off getting rid of the link entirely.

* <a href="http://www.exif.org/Exif2-2.PDF">
* {@code http://www.exif.org/Exif2-2.PDF}
* <a href="http://web.archive.org/web/20131018091152/http://exif.org/Exif2-2.PDF">
* {@code http://web.archive.org/web/20131018091152/http://exif.org/Exif2-2.PDF}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not point to web archives
https://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf seems like a better option.
Perhaps @bplb has another idea.

<a href="https://bugs.java.com/view_bug.do?bug_id=4030718">
<a href="https://bugs.openjdk.org/browse/JDK-4030718">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK 1.4 launched over 20 years ago. I think we can just scrap the link.
Maybe change the text to scrap mentioining it and just leave the text starting with

"AWT terminates all its helper threads allowing .. "

@@ -154,11 +154,11 @@ <h3>
<ul>
<li> Other packages can create displayable components for internal
needs and never make them undisplayable. See
<a href="https://bugs.java.com/view_bug.do?bug_id=4515058">
<a href="https://bugs.openjdk.org/browse/JDK-4515058">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about Solaris IMF .. I think we don't need to worry about it any more.

4515058</a>,
<a href="https://bugs.java.com/view_bug.do?bug_id=4671025">
<a href="https://bugs.openjdk.org/browse/JDK-4671025">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And even better it was resolved in 1.5 under this bug id which I guess was still open when this doc was written

4671025</a>, and
<a href="https://bugs.java.com/view_bug.do?bug_id=4465537">
<a href="https://bugs.openjdk.org/browse/JDK-4465537">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug was about some off-screen image problem with JScrollBar
It was closed as a dup of 4417287 which was fixed in 1.4

So in summary it is wrong to keep these linked bugs in here.
Remove the lot of them

@prsadhuk
Copy link
Contributor Author

will be done in jdk19 forked repo

@prsadhuk prsadhuk closed this Jun 20, 2022
@prsadhuk prsadhuk deleted the JDK-8288528 branch June 14, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
3 participants