Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289078: Make STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN fields static in ProcessHandleImpl #9196

Closed

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Jun 17, 2022

Fields STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN are actually unused, but they are useful as documentation on the interface to native.
Make them static to reduce memory usage.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289078: Make STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN fields static in ProcessHandleImpl

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9196/head:pull/9196
$ git checkout pull/9196

Update a local copy of the PR:
$ git checkout pull/9196
$ git pull https://git.openjdk.org/jdk pull/9196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9196

View PR using the GUI difftool:
$ git pr show -t 9196

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9196.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 17, 2022
@turbanoff turbanoff changed the title [PATCH] Make STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN fields static in ProcessHandleImpl 8289078: Make STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN fields static in ProcessHandleImpl Jun 23, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 23, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 23, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289078: Make STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN fields static in ProcessHandleImpl

Reviewed-by: jpai, rriggs, bpb, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • 0828881: 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java
  • 4cdb978: 8289098: clean up ported serviceability/jvmti tests
  • 9918b6d: 8288609: Update --release 19 symbol information for JDK 19 build 28
  • f67c536: 8288935: Remove excessive includes introduced in loom
  • 239b4bb: 8289095: (fs) UnixCopyFile build error on linux-x86
  • 0d2952e: 8289129: [BACKOUT] JDK-8287281 adjust guarantee in Handshake::execute for the case of target thread being current
  • fdc8455: 8288495: [test] Make OutputAnalyzer exception more informative
  • 925084c: 8288976: classfile parser 'wrong name' error message has the names the wrong way around
  • 17aacde: 8288669: compiler/vectorapi/VectorFPtoIntCastTest.java still fails with "IRViolationException: There were one or multiple IR rule failures."
  • 9dc9a64: 8287281: adjust guarantee in Handshake::execute for the case of target thread being current
  • ... and 77 more: https://git.openjdk.org/jdk/compare/523d553e13e7d6fbf0a3befb1c18431738fe8d7f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2022
Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

Going to push as commit 47fe9ef.
Since your change was applied there have been 92 commits pushed to the master branch:

  • 62e1e79: 8289147: unify os::infinite_sleep on posix platforms
  • de74671: 8266670: Better modeling of access flags in core reflection
  • a5c25d8: 8286395: Address possibly lossy conversions in java.security.jgss
  • e93be3a: 8286389: Address possibly lossy conversions in jdk.crypto.ec
  • 53b37fe: 8288130: compiler error with AP and explicit record accessor
  • 0828881: 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java
  • 4cdb978: 8289098: clean up ported serviceability/jvmti tests
  • 9918b6d: 8288609: Update --release 19 symbol information for JDK 19 build 28
  • f67c536: 8288935: Remove excessive includes introduced in loom
  • 239b4bb: 8289095: (fs) UnixCopyFile build error on linux-x86
  • ... and 82 more: https://git.openjdk.org/jdk/compare/523d553e13e7d6fbf0a3befb1c18431738fe8d7f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2022
@openjdk openjdk bot closed this Jun 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@turbanoff Pushed as commit 47fe9ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the static_STARTTIME_ProcessHandleImpl branch October 27, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
6 participants