Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8286389: Address possibly lossy conversions in jdk.crypto.ec #9203

Closed
wants to merge 1 commit into from
Closed

8286389: Address possibly lossy conversions in jdk.crypto.ec #9203

wants to merge 1 commit into from

Conversation

rjernst
Copy link
Contributor

@rjernst rjernst commented Jun 17, 2022 •
edited by openjdk bot
Loading

Applied required casts in jdk.crypto.ec for the upcoming warning.
Verified by cherry-picking @asotona's patch.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286389: Address possibly lossy conversions in jdk.crypto.ec

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9203/head:pull/9203
$ git checkout pull/9203

Update a local copy of the PR:
$ git checkout pull/9203
$ git pull https://git.openjdk.org/jdk pull/9203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9203

View PR using the GUI difftool:
$ git pr show -t 9203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9203.diff

@rjernst
8286389: Address possibly lossy conversions in jdk.crypto.ec
9444694 
Applied required casts in jdk.crypto.ec for the upcoming warning.
Verified by cherry-picking @asotona's patch.
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2022

👋 Welcome back rjernst! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2022
@openjdk
Copy link

openjdk bot commented Jun 17, 2022

@rjernst The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 17, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2022

Webrevs

ChrisHegarty
ChrisHegarty approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm happy to sponsor this change, once a reviewer from the security area has had a chance to take a look.

@openjdk
Copy link

openjdk bot commented Jun 17, 2022 •
edited
Loading

@rjernst This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286389: Address possibly lossy conversions in jdk.crypto.ec

Reviewed-by: chegar, xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ChrisHegarty, @XueleiFan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2022
@dfuch
Copy link
Member

dfuch commented Jun 21, 2022

Looks reasonable to me - but it would be good to have someone from security-dev take a look.

XueleiFan
XueleiFan reviewed Jun 21, 2022
View reviewed changes
src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPublicKeyImpl.java
@@ -76,7 +76,7 @@ public final class XDHPublicKeyImpl extends X509Key implements XECPublicKey {
// clear the extra bits
int bitsMod8 = params.getBits() % 8;
if (bitsMod8 != 0) {
int mask = (1 << bitsMod8) - 1;
byte mask = (byte) ((1 << bitsMod8) - 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not insert a whitespace after the "(byte)" conversion. Similar to following update. Otherwise, looks good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the cast style in EdDSAOperations.java. Should I change this one and leave the other, change both, or leave these as is to be consistent? I don't particularly mind which way it is, I'll do whatever you suggest.

@rjernst
Copy link
Contributor Author

rjernst commented Jun 24, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@rjernst
Your change (at version 9444694) is now ready to be sponsored by a Committer.

@ChrisHegarty
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 25, 2022

Going to push as commit e93be3a.
Since your change was applied there have been 91 commits pushed to the master branch:

  • 53b37fe: 8288130: compiler error with AP and explicit record accessor
  • 0828881: 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java
  • 4cdb978: 8289098: clean up ported serviceability/jvmti tests
  • 9918b6d: 8288609: Update --release 19 symbol information for JDK 19 build 28
  • f67c536: 8288935: Remove excessive includes introduced in loom
  • 239b4bb: 8289095: (fs) UnixCopyFile build error on linux-x86
  • 0d2952e: 8289129: [BACKOUT] JDK-8287281 adjust guarantee in Handshake::execute for the case of target thread being current
  • fdc8455: 8288495: [test] Make OutputAnalyzer exception more informative
  • 925084c: 8288976: classfile parser 'wrong name' error message has the names the wrong way around
  • 17aacde: 8288669: compiler/vectorapi/VectorFPtoIntCastTest.java still fails with "IRViolationException: There were one or multiple IR rule failures."
  • ... and 81 more: https://git.openjdk.org/jdk/compare/e833c1d179f926edabb2d40c6c357ab20bba726e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2022
@openjdk openjdk bot closed this Jun 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 25, 2022
@openjdk
Copy link

openjdk bot commented Jun 25, 2022

@ChrisHegarty @rjernst Pushed as commit e93be3a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

@XueleiFan XueleiFan XueleiFan approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjernst @dfuch @ChrisHegarty @XueleiFan