Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails #921

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 29, 2020

The test draws some specific pattern to the VolatileImage and to the BufferedImage, and then compare pixels.

The test uses the getSnapshot() method to get the pixels from VolatileImage, and this method produces some interpolation "artifacts" if the fractional scale is used in the system(like 125%).

The solution is to use some predefined scale factors.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/921/head:pull/921
$ git checkout pull/921

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2020
@openjdk
Copy link

openjdk bot commented Oct 29, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Oct 29, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2020

Webrevs

@jayathirthrao
Copy link
Member

Please add CI test link in JBS. Looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 3, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 84 new commits pushed to the master branch:

  • 4107670: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS
  • 9a36747: 8255780: Remove unused overloads of VMError::report_and_die()
  • c96a914: 8255662: ZGC: Unify nmethod closures in the heap iterator
  • aa2862a: 8255741: Zero: print signal name in unhandled signal handler
  • 1580574: 8255672: Replace PhaseTransform::eqv by pointer equality check
  • e7a2d5c: 8252533: Signal handlers should run with synchronous error signals unblocked
  • 6d36b4b: 8255743: Relax SIGFPE match in in runtime/ErrorHandling/SecondaryErrorTest.java
  • f0eeca9: 8255718: Zero: VM should know it runs in interpreter-only mode
  • 9beb866: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos
  • fe4e6b3: 8196089: javax/swing/Action/8133039/bug8133039.java fails
  • ... and 74 more: https://git.openjdk.java.net/jdk/compare/7e305ad1d405a7c7bd8edcb49fc105fdfafeb323...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 3, 2020
@mrserb
Copy link
Member Author

mrserb commented Nov 3, 2020

/integrate

@openjdk openjdk bot closed this Nov 3, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2020
@openjdk
Copy link

openjdk bot commented Nov 3, 2020

@mrserb Since your change was applied there have been 98 commits pushed to the master branch:

  • 134e22a: 8255606: Enable concurrent stack processing on x86_32 platforms
  • ca216ba: 8255810: Zero: build fails without JVMTI
  • d47336b: 8248320: Provide a unique accessible name for
  • 64a9811: 8255798: Remove dead headless code in CompileJavaModules.gmk
  • 364b0fe: 8255801: Race when building ct.sym build tools
  • f389a71: 8255737: Zero: DO_UPDATE_INSTRUCTION_COUNT should only update when relevant VM flags are set
  • 93ef009: 8255762: Shenandoah: Consolidate/streamline interpreter LRBs
  • 63461d5: 8255072: [TESTBUG] com/sun/jdi/EATests.java should not fail if expected VMOutOfMemoryException is not thrown
  • b8d4e02: 8255374: Add a dropReturn MethodHandle combinator
  • 1d0bd50: 8254758: Change G1ServiceThread to be task based
  • ... and 88 more: https://git.openjdk.java.net/jdk/compare/7e305ad1d405a7c7bd8edcb49fc105fdfafeb323...master

Your commit was automatically rebased without conflicts.

Pushed as commit 83f3cf4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8196087 branch April 12, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants