Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288744: Remove tools/jlink/plugins/CompressorPluginTest.java from problemlist #9221

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Jun 21, 2022

Can I please get a review for this change which proposes to remove the CompressorPluginTest from the problemlist?

This test was problem listed since it had intermittently failed with odd exception in the past (https://bugs.openjdk.org/browse/JDK-8247407). Over the past several months I have attempted multiple runs of this test (with very high test repeats) both locally as well as a CI setup to see if this is still reproducible. So far, I haven't been able to reproduce it. Given the odd exception it was throwing originally, it's hard to say what the issue could have been (and whether it got fixed in recent times), but since it isn't reproducible now, I would like to remove this from the problemlist. If it does fail again, I'll go ahead and collect some additional details to help narrow this down.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288744: Remove tools/jlink/plugins/CompressorPluginTest.java from problemlist

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9221/head:pull/9221
$ git checkout pull/9221

Update a local copy of the PR:
$ git checkout pull/9221
$ git pull https://git.openjdk.org/jdk pull/9221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9221

View PR using the GUI difftool:
$ git pr show -t 9221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9221.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2022

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@jaikiran To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@jaikiran
Copy link
Member Author

/label core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 21, 2022
@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@jaikiran
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Jun 21, 2022

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288744: Remove tools/jlink/plugins/CompressorPluginTest.java from problemlist

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • ad89146: 8288601: Consolidate static/dynamic archive tables
  • 7e211d7: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run
  • 7039c66: Merge
  • 453e8be: 8288527: broken link in java.base/java/util/zip/package-summary.html
  • 33d0363: 8288741: JFR: Change package name of snippet files
  • 0408f9c: 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state
  • 1cf83a4: 8287800: JFR: Incorrect error message when starting recording with missing .jfc file
  • 09da87c: 8288485: jni/nullCaller/NullCallerTest.java failing (ppc64)
  • ed714af: 8288564: C2: LShiftLNode::Ideal produces wrong result after JDK-8278114
  • ae030bc: 8288397: AArch64: Fix register issues in SVE backend match rules
  • ... and 4 more: https://git.openjdk.org/jdk/compare/a7df5a40639a4d3138616c9fc1b144381240d2e5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 21, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2022

Webrevs

@jaikiran
Copy link
Member Author

Thank you Alan for the review.

@jaikiran
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

Going to push as commit affbd72.
Since your change was applied there have been 33 commits pushed to the master branch:

  • 2bf5c9a: Merge
  • 70008da: 8287971: Throw exception for missing values in .jpackage.xml
  • d7b43af: 8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0
  • 834d92d: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
  • 198cec9: 8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"
  • 97200a7: 8278053: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing in loom repo with Xcomp
  • 31d981e: 8288532: additional review changes for JDK-8286830
  • a144988: 8288139: JavaThread touches oop after GC barrier is detached
  • e26d3b3: 8288497: add support for JavaThread::is_oop_safe()
  • c74a923: 8288531: Empty spans in mobile navigation markup
  • ... and 23 more: https://git.openjdk.org/jdk/compare/a7df5a40639a4d3138616c9fc1b144381240d2e5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 22, 2022
@openjdk openjdk bot closed this Jun 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@jaikiran Pushed as commit affbd72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants