8288926: make runtime/logging/DeoptStats.java more reliable

[navyxliu]

Currently, the test only triggers one deoptimization and it is not the test itself. In JDK-8287385, we suppress the superficial unstable_if traps and then we can't pass this test. We would like to make sure the test triggers a deoptimization itself and is not subject to external environment.

Before this change, vmOutput.log has the following information.

<statistics type='deoptimization'>
Deoptimization traps recorded:
     1 (100.0%) total
         unstable_if/reinterpret/if_icmpeq: 1 (100.0%)
</statistics>

After this change, it contains 2 deoptimizations. The null-check deopt comes from the test itself.

<statistics type='deoptimization'>
Deoptimization traps recorded:
     2 (100.0%) total
       null_check/maybe_recompile/getfield: 1 (50.0%)
         unstable_if/reinterpret/if_icmpeq: 1 (50.0%)
</statistics>

Test:

$make test TEST="runtime/logging/DeoptStats.java" CONF=linux-x86_64-server-release LOG=info

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288926: make runtime/logging/DeoptStats.java more reliable

Reviewers

• Volker Simonis (@simonis - Reviewer)
• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9228/head:pull/9228
$ git checkout pull/9228

Update a local copy of the PR:
$ git checkout pull/9228
$ git pull https://git.openjdk.org/jdk pull/9228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9228

View PR using the GUI difftool:
$ git pr show -t 9228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9228.diff

[bridgekeeper]

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@navyxliu The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (54a8a978)

[simonis]

Change looks good. Thanks for catching this!

[openjdk]

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288926: make runtime/logging/DeoptStats.java more reliable

Reviewed-by: simonis, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 270cf67: 8288752: Split thread implementation files
• d51f4f4: 8287011: Improve container information
• affbd72: 8288744: Remove tools/jlink/plugins/CompressorPluginTest.java from problemlist
• 2bf5c9a: Merge
• 70008da: 8287971: Throw exception for missing values in .jpackage.xml
• d7b43af: 8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0
• 834d92d: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
• 198cec9: 8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"
• 97200a7: 8278053: serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java failing in loom repo with Xcomp
• 31d981e: 8288532: additional review changes for JDK-8286830
• ... and 14 more: https://git.openjdk.org/jdk/compare/7039c6616ad1b67320f08e7ea4763e8ff4977430...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[phohensee]

Lgtm.

[navyxliu]

/integrate

[openjdk]

Going to push as commit 82c77ca.
Since your change was applied there have been 26 commits pushed to the master branch:

• d4de475: 8287868: Localized names update in COMPAT locale provider
• 50c37f5: 8276798: HttpURLConnection sends invalid HTTP request
• 270cf67: 8288752: Split thread implementation files
• d51f4f4: 8287011: Improve container information
• affbd72: 8288744: Remove tools/jlink/plugins/CompressorPluginTest.java from problemlist
• 2bf5c9a: Merge
• 70008da: 8287971: Throw exception for missing values in .jpackage.xml
• d7b43af: 8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0
• 834d92d: 8288754: GCC 12 fails to build zReferenceProcessor.cpp
• 198cec9: 8286103: VThreadMonitorTest fails "assert(!current->cont_fastpath() || (current->cont_fastpath_thread_state() && !interpreted_native_or_deoptimized_on_stack(current))) failed"
• ... and 16 more: https://git.openjdk.org/jdk/compare/7039c6616ad1b67320f08e7ea4763e8ff4977430...master

Your commit was automatically rebased without conflicts.

[openjdk]

@navyxliu Pushed as commit 82c77ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.