New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable #923
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
Webrevs
|
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 146 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
The test fails if OutOfMemoryError is thrown, right? |
It depends on the system, if it is really slow and just a few iterations out of 5000 will be done then the original bug will not be caught. If the system is fast and all 5000 iterations will be done, then the bug will be found. |
I agree with the idea of minimising the time spent to run the test. But the test is useless if it has no time to fail. I just ran the test on my laptop with 10+22 where the original bug JDK-8175015 isn't fixed. It fails as one would expect. It took about 12 minutes with But the modified test times out after 1.5 minutes and the test does not fail. Thus 90 seconds limit seems too short. Shall we increase the timeout to 5 minutes at least and reduce the heap size to make the test fail faster. The number of iterations can be reduced as well, say to 10,000. The test runs quickly on a recent build, it takes less than 10 seconds to perform 50,000 iterations. To be precise, it took 5.5 seconds with |
I have increase timeout, but still use the xmx8m, it is the safest value, for the less value the java sometimes cannot be started using some options/configs. |
Makes sense. |
/integrate |
@mrserb Since your change was applied there have been 150 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e730e8b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The test may work up to 15 minutes on some systems.
The solution is to limit the time execution to 90 seconds.
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/923/head:pull/923
$ git checkout pull/923