8288935: Remove excessive includes introduced in loom

[iklam]

Some header files introduced in loom has unnecessary #includes.

Also, some hpp files have complex inline functions that should be moved to either inline.hpp or cpp files.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288935: Remove excessive includes introduced in loom

Reviewers

• Robbin Ehn (@robehn - Reviewer) ⚠️ Review applies to 59ae33d6
• Stefan Karlsson (@stefank - Reviewer) ⚠️ Review applies to 59ae33d6

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9231/head:pull/9231
$ git checkout pull/9231

Update a local copy of the PR:
$ git checkout pull/9231
$ git pull https://git.openjdk.org/jdk pull/9231/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9231

View PR using the GUI difftool:
$ git pr show -t 9231

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9231.diff

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (15d72ca4)
• 01: Full - Incremental (72db1c0b)
• 00: Full (59ae33d6)

[robehn]

Thanks, looks good.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288935: Remove excessive includes introduced in loom

Reviewed-by: rehn, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 9dc9a64: 8287281: adjust guarantee in Handshake::execute for the case of target thread being current

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[stefank]

Looks good. I saw one obvious missing include.

[stefank]

Needs utilities/align.hpp

[iklam]

Thanks to @stefank and @robehn for the review.

• Passes our CI tier1 and build-tier5.
• GHA linux-x86 errors are unrelated to my changes.

/integrate

[openjdk]

Going to push as commit f67c536.
Since your change was applied there have been 6 commits pushed to the master branch:

• 239b4bb: 8289095: (fs) UnixCopyFile build error on linux-x86
• 0d2952e: 8289129: [BACKOUT] JDK-8287281 adjust guarantee in Handshake::execute for the case of target thread being current
• fdc8455: 8288495: [test] Make OutputAnalyzer exception more informative
• 925084c: 8288976: classfile parser 'wrong name' error message has the names the wrong way around
• 17aacde: 8288669: compiler/vectorapi/VectorFPtoIntCastTest.java still fails with "IRViolationException: There were one or multiple IR rule failures."
• 9dc9a64: 8287281: adjust guarantee in Handshake::execute for the case of target thread being current

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit f67c536.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.