8288961: jpackage: test MSI installation fix

[akashche]

Please review this minor fix to the jpackage test suite.

When INSTALL and UNINSTALL actions are enabled for jpackage test suite runs (disabled by default), installation of EXE and MSI packages is performed. EXE package is invoked directly and MSI package is installed using msiexec utility. In both cases the path of the packages starts with a "." (current dir) symbol, it is processed correctly with EXE installation, but not with MSI, example:

[03:52:19.634] TRACE: assertTrue(): Check [.\\test.bcc14973\\output\\FileAssociationsTest-1.0.msi] path exists
[03:52:19.634] TRACE: assertTrue(): Check [.\\test.bcc14973\\output\\FileAssociationsTest-1.0.msi] is a file
[03:52:19.634] TRACE: exec: Execute [msiexec /qn /norestart /i .\\test.bcc14973\\output\\FileAssociationsTest-1.0.msi](5); discard I/O...
[03:52:19.790] TRACE: exec: Done. Exit code: 1619
[03:52:19.805] ERROR: Expected [0]. Actual [1619]: Check command [msiexec /qn /norestart /i .\\test.bcc14973\\output\\FileAssociationsTest-1.0.msi](5) exited with 0 code 

Is is proposed to normalize the path passed to msiexec, in this case installation will succeed:

[03:56:52.429] TRACE: assertTrue(): Check [.\\test.bcc14973\\output\\FileAssociationsTest-1.0.msi] path exists
[03:56:52.429] TRACE: assertTrue(): Check [.\\test.bcc14973\\output\\FileAssociationsTest-1.0.msi] is a file
[03:56:52.429] TRACE: exec: Execute [msiexec /qn /norestart /i test.bcc14973\\output\\FileAssociationsTest-1.0.msi](5); discard I/O...
[03:56:57.067] TRACE: exec: Done. Exit code: 0
[03:56:57.067] TRACE: assertEquals(0): Check command [msiexec /qn /norestart /i test.bcc14973\\output\\FileAssociationsTest-1.0.msi](5) exited with 0 code

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288961: jpackage: test MSI installation fix

Reviewers

• Alexey Semenyuk (@alexeysemenyukoracle - Reviewer)
• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9236/head:pull/9236
$ git checkout pull/9236

Update a local copy of the PR:
$ git checkout pull/9236
$ git pull https://git.openjdk.org/jdk pull/9236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9236

View PR using the GUI difftool:
$ git pr show -t 9236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9236.diff

[bridgekeeper]

👋 Welcome back akasko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@akashche The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9a5982a0)

[openjdk]

@akashche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288961: jpackage: test MSI installation fix

Reviewed-by: asemenyuk, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

• b4ab5fe: 8288396: Always create reproducible builds
• 3336971: 8289258: ProblemList some failing custom loader tests with ZGC
• 784fa0a: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
• ca78f7b: 8286259: Password cleanup after KeyStore.PasswordProtection in P11KeyStore
• e322e77: 8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name
• 40bf3b1: 8288993: Make AwtFramePackTest generic by removing @requires tag
• d4b040f: Merge
• 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
• 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
• 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
• ... and 57 more: https://git.openjdk.org/jdk/compare/affbd72aa3dce80e2ad54ff775c6f7469f38b05b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeysemenyukoracle, @sashamatveev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[akashche]

Thanks for the reviews! I don't have Committer role in JDK Project, would appreciate if someone can push it.

[akashche]

/integrate

[openjdk]

@akashche
Your change (at version 9a5982a) is now ready to be sponsored by a Committer.

[alexeysemenyukoracle]

/sponsor

[openjdk]

Going to push as commit c67149b.
Since your change was applied there have been 72 commits pushed to the master branch:

• 1f36ed1: 8288013: jpackage: test utility Windows registry enhancement
• 88fe19c: 8289071: Compute allocation sizes of stubs and nmethods outside of lock protection
• d4eeeb8: 8271252: os::reserve_memory should not use mtOther as default NMT flag
• 549c6c2: 8287818: Shenandoah: adapt nmethod arming from Loom
• aa43824: 8289138: G1: Remove redundant is-marking-active checks in C1 barrier
• b4ab5fe: 8288396: Always create reproducible builds
• 3336971: 8289258: ProblemList some failing custom loader tests with ZGC
• 784fa0a: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
• ca78f7b: 8286259: Password cleanup after KeyStore.PasswordProtection in P11KeyStore
• e322e77: 8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name
• ... and 62 more: https://git.openjdk.org/jdk/compare/affbd72aa3dce80e2ad54ff775c6f7469f38b05b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle @akashche Pushed as commit c67149b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.