Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7194219: java/awt/Component/UpdatingBootTime/UpdatingBootTime.html fails on Linux #925

Closed
wants to merge 2 commits into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 29, 2020

The test checks that the timestamp of the mouse event accurately represents the current time of the system, even if the time of the system is jumped to the past/future.

On Unix in xawt we calculate the timstamp using this method:
reset_time_utc = System.currentTimeMillis() - getCurrentServerTime();
timstamp = reset_time_utc + server_offset;

(1.) Note that the "server_offset" - timstamp when the native event was generated, and we try to convert it to the UTC timestamp. Unfortunatly we callculate the "reset_time_utc" only once at the start of the application and then rarely update it. So if the time in the system is changed we still use the old one.

The exactly the same bug described at (1.) was fixed on windows by the https://bugs.openjdk.java.net/browse/JDK-6461933 and for that bug the test in question was created. That bug was fixed by the "recalculation" system time more often. But it does not solve the general time issue and the code was reworked again by the https://bugs.openjdk.java.net/browse/JDK-8046495

I would like to fix the current bug in the same was as on windows, see link below:
https://bugs.openjdk.java.net/browse/JDK-8046495?focusedCommentId=13517205&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13517205

After the fix we will use the same System.currentTimeMillis()/JVM_CurrentTimeMillis on all platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-7194219: java/awt/Component/UpdatingBootTime/UpdatingBootTime.html fails on Linux

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/925/head:pull/925
$ git checkout pull/925

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 29, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Oct 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 29, 2020

Webrevs

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 26, 2020

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 30, 2020

Any volunteers for a review?

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 28, 2020

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

@mrserb mrserb commented Dec 31, 2020

Any volunteers for a review?

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7194219: java/awt/Component/UpdatingBootTime/UpdatingBootTime.html fails on Linux

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

  • 33fbc10: 8259025: Record compact constructor using Objects.requireNonNull
  • 23801da: 8259482: jni_Set/GetField_probe are the same as their _nh versions
  • 01b2804: 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears to not be fully fixed
  • 1bd015f: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
  • 2354882: 8250768: javac should be adapted to changes in JEP 12
  • 18a37f9: 8259368: Zero: UseCompressedClassPointers does not depend on UseCompressedOops
  • a03e22b: 8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp
  • e0d748d: 8258606: os::print_signal_handlers() should resolve the function name of the handlers
  • bd34418: 8258445: Move make/templates to make/data
  • d21a0ea: 8258449: Move make/hotspot/symbols to make/data
  • ... and 62 more: https://git.openjdk.java.net/jdk/compare/67c221148159d94142a3a6d9ddadce2dff8c858b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 11, 2021
@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 12, 2021

/integrate

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@mrserb Since your change was applied there have been 93 commits pushed to the master branch:

  • 77f6290: 8258254: Move PtrQueue flush to PtrQueueSet subclasses
  • 2255ab7: 8258810: Improve enum traits
  • ae0532e: 8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend
  • b378f54: Merge
  • 2cb271e: 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
  • d60a937: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl
  • e05f36f: 8259043: More Zero architectures need linkage with libatomic
  • 020ec84: 8259429: Update reference to README.md
  • fb68395: 8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)
  • b6d51e1: 8259585: Accessible actions do not work on mac os x
  • ... and 83 more: https://git.openjdk.java.net/jdk/compare/67c221148159d94142a3a6d9ddadce2dff8c858b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 61c5b95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-7194219 branch Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants