8289006: Cleanup from thread.hpp split

[coleenp]

Remove extra include directives. Tested with GHA.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289006: Cleanup from thread.hpp split

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to f3e109c8
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9252/head:pull/9252
$ git checkout pull/9252

Update a local copy of the PR:
$ git checkout pull/9252
$ git pull https://git.openjdk.org/jdk pull/9252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9252

View PR using the GUI difftool:
$ git pr show -t 9252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9252.diff

[coleenp]

/test

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1a249ab4)
• 00: Full (f3e109c8)

[dholmes-ora]

One pre-existing nit but your changes look good.

Thanks.

[dholmes-ora]

Existing, but it is redundant to include the .hpp and the .inline.hpp file as the later always includes the former.

[coleenp]

You're right. I touched that line but didn't even see it. I confirmed stack_zero.inline.hpp includes stack_zero.hpp, so removed the latter from stack_zero.cpp. We'll let GHA confirm.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289006: Cleanup from thread.hpp split

Reviewed-by: dholmes, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 2728770: 8288589: Files.readString ignores encoding errors for UTF-16
• ef17ee4: 8288515: (ch) Unnecessary use of Math.addExact() in java.nio.channels.FileLock.overlaps()
• 72f286a: 8287580: (se) CancelledKeyException during channel registration
• b8db0c3: 6980847: (fs) Files.copy needs to be "tuned"
• d579916: 8288740: Change incorrect documentation for sjavac flag
• 26c03c1: 8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes
• a802b98: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used
• bf0623b: 8286314: Trampoline not created for far runtime targets outside small CodeCache
• 5b583e4: Merge
• 6458ebc: 8288988: ProblemList serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java in -Xcomp mode
• ... and 9 more: https://git.openjdk.org/jdk/compare/270cf67e5ff19b082f710d52831f436dd144d883...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

Thumbs up. Thanks for taking care of my late comments.

[coleenp]

Thanks Dan for the comments, and David for reviewing. Pushing as trivial.
/integrate

[openjdk]

Going to push as commit b206d2d.
Since your change was applied there have been 19 commits pushed to the master branch:

• 2728770: 8288589: Files.readString ignores encoding errors for UTF-16
• ef17ee4: 8288515: (ch) Unnecessary use of Math.addExact() in java.nio.channels.FileLock.overlaps()
• 72f286a: 8287580: (se) CancelledKeyException during channel registration
• b8db0c3: 6980847: (fs) Files.copy needs to be "tuned"
• d579916: 8288740: Change incorrect documentation for sjavac flag
• 26c03c1: 8288719: [arm32] SafeFetch32 thumb interleaving causes random crashes
• a802b98: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used
• bf0623b: 8286314: Trampoline not created for far runtime targets outside small CodeCache
• 5b583e4: Merge
• 6458ebc: 8288988: ProblemList serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java in -Xcomp mode
• ... and 9 more: https://git.openjdk.org/jdk/compare/270cf67e5ff19b082f710d52831f436dd144d883...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit b206d2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.