8286259: Password cleanup after KeyStore.PasswordProtection in P11KeyStore

[haimaychao]

Please review the small update for JDK-8286259.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286259: Password cleanup after KeyStore.PasswordProtection in P11KeyStore

Reviewers

• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9254/head:pull/9254
$ git checkout pull/9254

Update a local copy of the PR:
$ git checkout pull/9254
$ git pull https://git.openjdk.org/jdk pull/9254/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9254

View PR using the GUI difftool:
$ git pr show -t 9254

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9254.diff

[bridgekeeper]

👋 Welcome back hchao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@haimaychao The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d52ee13a)

[valeriepeng]

This particular change looks fine.
However, I noticed that there is another local PasswordProtection object inside the KeyStoreLoadParameter class in Secmod.java. Is that also subject to the same issue?

[openjdk]

@haimaychao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286259: Password cleanup after KeyStore.PasswordProtection in P11KeyStore

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• e322e77: 8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name
• 40bf3b1: 8288993: Make AwtFramePackTest generic by removing @requires tag
• d4b040f: Merge
• 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
• 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
• 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
• 20f55ab: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support
• bdf9902: 8288120: VerifyError with JEP 405 pattern match
• b0db333: 8288528: broken links in java.desktop
• 651cbeb: 8288080: (fc) FileChannel::map for MemorySegments should state it always throws UOE
• ... and 54 more: https://git.openjdk.org/jdk/compare/2bf5c9a6877b51377a535c6021a9e38549c89029...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[haimaychao]

/integrate

[openjdk]

Going to push as commit ca78f7b.
Since your change was applied there have been 64 commits pushed to the master branch:

• e322e77: 8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name
• 40bf3b1: 8288993: Make AwtFramePackTest generic by removing @requires tag
• d4b040f: Merge
• 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
• 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
• 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
• 20f55ab: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support
• bdf9902: 8288120: VerifyError with JEP 405 pattern match
• b0db333: 8288528: broken links in java.desktop
• 651cbeb: 8288080: (fc) FileChannel::map for MemorySegments should state it always throws UOE
• ... and 54 more: https://git.openjdk.org/jdk/compare/2bf5c9a6877b51377a535c6021a9e38549c89029...master

Your commit was automatically rebased without conflicts.

[openjdk]

@haimaychao Pushed as commit ca78f7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.