Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos #926

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 29, 2020

Please review a test fix for a test issue seen to be failing on mach5 macos systems due to timing issue.
Modified the test to added delay() after frame is made visible and moved the frame to centre of screen to be consistent with other tests.
Mach5 job has been run for several iterations in all platforms. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/926/head:pull/926
$ git checkout pull/926

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 29, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2020

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Oct 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 29, 2020

Webrevs

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 29, 2020

Please ask @jayathirthrao, who was able to reproduce this bug on the local system, about approval.

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Nov 2, 2020

I tested with or without fix in my local system with all the settings that we do for jtreg tests but still it fails in my system.
Someone else with 10.15 please verify the behaviour or we can say that it passes in our CI system and there is some specific issue with my system.

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Nov 2, 2020

If we dont give permission for "terminal" to control the computer in System Preferences -> Security & Privacy -> Privacy -> Accessibility i see that the test fails.

After enabling it i see that test passes without fix also. Looks like it was issue related to some settings.
Present change looks like some common test refactoring.

@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Nov 2, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 69f5235: 8255596: Mutex safepoint checking options and flags should be scoped enums
  • d05df7c: 8236842: Surprising 'multiple elements' behaviour from getTypeElement when cross-compiling with --release
  • 64feeab: 8255603: Memory/Performance regression after JDK-8210985
  • 518ff51: 8233569: [TESTBUG] JTextComponent test bug6361367.java fails on macos
  • 4c4b8f4: 8196302: javax/swing/JFileChooser/8041694/bug8041694.java
  • f61ce32: 8255576: (fs) Files.isHidden() throws ArrayIndexOutOfBoundsException (unix)
  • fe7672b: 8196099: javax/swing/text/CSSBorder/6796710/bug6796710.java fails
  • cacce84: 8169954: JFileChooser/8021253: java.lang.RuntimeException: Default button is not pressed
  • 7597cba: 8143021: [TEST_BUG] Test javax/swing/JColorChooser/Test6541987.java fails
  • 80380d5: 8255494: PKCS7 should use digest algorithm to verify the signature
  • ... and 32 more: https://git.openjdk.java.net/jdk/compare/caec8d2208fea0ddd4387a4530b4914645482377...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 2, 2020
@openjdk openjdk bot closed this Nov 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2020

@prsadhuk Since your change was applied there have been 43 commits pushed to the master branch:

  • e97809d: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos
  • 69f5235: 8255596: Mutex safepoint checking options and flags should be scoped enums
  • d05df7c: 8236842: Surprising 'multiple elements' behaviour from getTypeElement when cross-compiling with --release
  • 64feeab: 8255603: Memory/Performance regression after JDK-8210985
  • 518ff51: 8233569: [TESTBUG] JTextComponent test bug6361367.java fails on macos
  • 4c4b8f4: 8196302: javax/swing/JFileChooser/8041694/bug8041694.java
  • f61ce32: 8255576: (fs) Files.isHidden() throws ArrayIndexOutOfBoundsException (unix)
  • fe7672b: 8196099: javax/swing/text/CSSBorder/6796710/bug6796710.java fails
  • cacce84: 8169954: JFileChooser/8021253: java.lang.RuntimeException: Default button is not pressed
  • 7597cba: 8143021: [TEST_BUG] Test javax/swing/JColorChooser/Test6541987.java fails
  • ... and 33 more: https://git.openjdk.java.net/jdk/compare/caec8d2208fea0ddd4387a4530b4914645482377...master

Your commit was automatically rebased without conflicts.

Pushed as commit 98c91b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8233637 branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants