Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8288750: IGV: Improve Shortcuts #9260

Closed
wants to merge 16 commits into from

Conversation

tobiasholenstein
Copy link
Contributor

@tobiasholenstein tobiasholenstein commented Jun 23, 2022

Improvement of keyboard shortcuts in IGV under macOS:.
Certain keyboard/mouse shortcuts do not work under macOS. E.g. Ctrl + left-click to select multiple nodes. The reason is that this keyboard shortcut is hardwired as a right-click under macOS and cannot be easily changed in the operating system. In general, the macOS user manual recommends using "Command/Meta" as a modifier key instead of "Control."

Fixed focus of the Graph Tab:.
In IGV, shortcuts are linked to a component. Components are for example a Graph Tab, "Outline", "Filters", "Bytecode", "Control Flow" and "Properties". Shortcuts only work if the linked component is in focus. The focus can be changed with Ctrl + TAB or by clicking into the TAB component. The Graph Tab did not get the focus back when the user clicked on it. This needed to be fixed.

Fixing QuickSearch:
Netbeans' QuickSearchAction is a global component of which only one common instance exists. IGV used a workaround to repaint the search bar in a new graphics tab. On macOS, the search bar doubled in size with each new Graph Tab. In addition, keyboard shortcuts for the search bar did not work. This issue was fixed by adding the search bar whenever the tab gained focus, and removing it (by default) when a new tab gained focus. This way, no workaround is required, and the size and ability to use a keyboard shortcut are fixed.

Adding new actions to expand/shrink the difference selection:.
The user can expand/reduce the difference selection by moving the beginning/end of the selection with the mouse.
diff
This is something many users didn't know. Therefore two new buttons should make it more clear for the user that this functionality exists.
actions
By adding these button we can now also add keyboard shortcuts to expand/reduce the difference selection.

Fixed shortcuts for:

  • Add a single node in the graph to selection (Ctrl/Cmd + left-click)
  • Add a multiple node in the graph to selection (Ctrl/Cmd + left-click-drag)
  • Zoom in and out (Ctrl/Cmd + mouse-wheel)

Added new shortcuts for:

  • Search (Ctrl/Cmd - I and Ctrl/Cmd - F)
  • Undo (Ctrl/Cmd - Z)
  • Redo (Ctrl/Cmd - Y and Ctrl/Cmd - Shift - Z)
  • Show Next Graph (Ctrl/Cmd - RIGHT)
  • Expand the difference selection (Ctrl/Cmd - UP and Ctrl/Cmd - Shift - RIGHT)
  • Reduce the difference selection (Ctrl/Cmd - DOWN and Ctrl/Cmd - Shift - LEFT)
  • Show Previous Graph (Ctrl/Cmd - LEFT)
  • Show satellite view (Hold S)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9260/head:pull/9260
$ git checkout pull/9260

Update a local copy of the PR:
$ git checkout pull/9260
$ git pull https://git.openjdk.org/jdk pull/9260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9260

View PR using the GUI difftool:
$ git pr show -t 9260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9260.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2022

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 23, 2022
@tobiasholenstein tobiasholenstein marked this pull request as ready for review June 24, 2022 08:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 24, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2022

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice improvement, thanks for fixing these and adding new shortcuts together with icons! I've tried the shortcuts out and they seem to work fine (tested on Ubuntu 20.04). It makes the workflow a lot easier.

I only have some minor code style comments, otherwise it looks good - but I'm not very familiar with the IGV code.

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288750: IGV: Improve Shortcuts

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 7905788: 8289126: Cleanup unnecessary null comparison before instanceof check in jdk.hotspot.agent
  • 47fe9ef: 8289078: Make STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN fields static in ProcessHandleImpl
  • 62e1e79: 8289147: unify os::infinite_sleep on posix platforms
  • de74671: 8266670: Better modeling of access flags in core reflection
  • a5c25d8: 8286395: Address possibly lossy conversions in java.security.jgss
  • e93be3a: 8286389: Address possibly lossy conversions in jdk.crypto.ec
  • 53b37fe: 8288130: compiler error with AP and explicit record accessor
  • 0828881: 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java
  • 4cdb978: 8289098: clean up ported serviceability/jvmti tests
  • 9918b6d: 8288609: Update --release 19 symbol information for JDK 19 build 28
  • ... and 20 more: https://git.openjdk.org/jdk/compare/5b583e4792b1d59891495a4a050fcdd4d38dfee1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2022
tobiasholenstein and others added 3 commits June 27, 2022 09:24
…pot/igv/view/EditorTopComponent.java


code style

Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
…pot/igv/view/actions/OverviewAction.java


added missing ")"

Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
…pot/igv/view/actions/CustomSelectAction.java


code style

Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2022
tobiasholenstein and others added 4 commits June 27, 2022 09:27
…pot/igv/view/actions/CustomSelectAction.java


code style

Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
…un/hotspot/igv/coordinator/actions/ImportAction.java


code style

Co-authored-by: Christian Hagedorn <christian.hagedorn@oracle.com>
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2022
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@tobiasholenstein
Copy link
Contributor Author

@chhagedorn and @TobiHartmann thanks for the reviews! :)

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing the updates!

@tobiasholenstein
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

Going to push as commit be6be15.
Since your change was applied there have been 33 commits pushed to the master branch:

  • 210a06a: 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled.
  • 64f95cf: 8012675: javax.swing.JEditorPane is unclear on the handling of unsupported HTML script tags
  • ddb55ed: 8135292: Remove duplicate code in Address.java in SA
  • 7905788: 8289126: Cleanup unnecessary null comparison before instanceof check in jdk.hotspot.agent
  • 47fe9ef: 8289078: Make STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN fields static in ProcessHandleImpl
  • 62e1e79: 8289147: unify os::infinite_sleep on posix platforms
  • de74671: 8266670: Better modeling of access flags in core reflection
  • a5c25d8: 8286395: Address possibly lossy conversions in java.security.jgss
  • e93be3a: 8286389: Address possibly lossy conversions in jdk.crypto.ec
  • 53b37fe: 8288130: compiler error with AP and explicit record accessor
  • ... and 23 more: https://git.openjdk.org/jdk/compare/5b583e4792b1d59891495a4a050fcdd4d38dfee1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2022
@openjdk openjdk bot closed this Jun 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@tobiasholenstein Pushed as commit be6be15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tobiasholenstein tobiasholenstein deleted the JDK-8288750 branch August 22, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants