Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath #9263

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Jun 23, 2022

Use InputStream.readAllBytes instead of manually written method.

Skipped this method in JDK-8080272


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9263/head:pull/9263
$ git checkout pull/9263

Update a local copy of the PR:
$ git checkout pull/9263
$ git pull https://git.openjdk.org/jdk pull/9263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9263

View PR using the GUI difftool:
$ git pr show -t 9263

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9263.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 23, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 23, 2022
@turbanoff turbanoff changed the title [PATCH] Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath 8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath Jul 4, 2022
@openjdk
Copy link

openjdk bot commented Jul 4, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289659: Refactor I/O stream copying to use InputStream.readAllBytes in X509CertPath

Reviewed-by: attila, weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 407 new commits pushed to the master branch:

  • 1e270ea: 8290780: AArch64: Crash in c2 nmethod running RunThese30M.java
  • b17269a: 8290959: Consistently use "grey" instead of "gray" in GC code
  • 350808a: 8290459: Remove unused GCCause enums
  • d0c365a: 8170794: [macosx] Error when using setDesktopManager on a JDesktopPane on MacOS X with Look and Feel Aqua
  • 80dc6ce: 8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures."
  • 228e8e9: 8290700: Optimize AArch64 nmethod entry barriers
  • 852e71d: 8290870: NMT: Increase MallocSiteTable size and allocate it only when needed
  • 0599a05: 8290900: Build failure with Clang 14+ due to function warning attribute
  • 987656d: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • 2660a92: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload
  • ... and 397 more: https://git.openjdk.org/jdk/compare/c8cc94a38423c0cef597986fb51938a26dc20b51...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2022

Webrevs

@turbanoff
Copy link
Member Author

I think we need approve from security team.
@seanjmullan @wangweij can you please have a look?

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2022

Going to push as commit 0ca74f5.
Since your change was applied there have been 407 commits pushed to the master branch:

  • 1e270ea: 8290780: AArch64: Crash in c2 nmethod running RunThese30M.java
  • b17269a: 8290959: Consistently use "grey" instead of "gray" in GC code
  • 350808a: 8290459: Remove unused GCCause enums
  • d0c365a: 8170794: [macosx] Error when using setDesktopManager on a JDesktopPane on MacOS X with Look and Feel Aqua
  • 80dc6ce: 8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures."
  • 228e8e9: 8290700: Optimize AArch64 nmethod entry barriers
  • 852e71d: 8290870: NMT: Increase MallocSiteTable size and allocate it only when needed
  • 0599a05: 8290900: Build failure with Clang 14+ due to function warning attribute
  • 987656d: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • 2660a92: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload
  • ... and 397 more: https://git.openjdk.org/jdk/compare/c8cc94a38423c0cef597986fb51938a26dc20b51...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2022
@openjdk openjdk bot closed this Jul 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@turbanoff Pushed as commit 0ca74f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the use_InputStream.readAllBytes_in_X509CertPath branch October 27, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
4 participants