8289138: G1: Remove redundant is-marking-active checks in C1 barrier

[albertnetymk]

Simple change of removing a redundant check in C1 barrier code.

Test: tier1-3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289138: G1: Remove redundant is-marking-active checks in C1 barrier

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Erik Helin (@edvbld - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9274/head:pull/9274
$ git checkout pull/9274

Update a local copy of the PR:
$ git checkout pull/9274
$ git pull https://git.openjdk.org/jdk pull/9274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9274

View PR using the GUI difftool:
$ git pr show -t 9274

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9274.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cc1681a6)

[tschatzl]

Lgtm.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289138: G1: Remove redundant is-marking-active checks in C1 barrier

Reviewed-by: tschatzl, ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• 3336971: 8289258: ProblemList some failing custom loader tests with ZGC
• 784fa0a: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
• ca78f7b: 8286259: Password cleanup after KeyStore.PasswordProtection in P11KeyStore
• e322e77: 8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name
• 40bf3b1: 8288993: Make AwtFramePackTest generic by removing @requires tag
• d4b040f: Merge
• 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
• 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
• 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
• 20f55ab: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support
• ... and 55 more: https://git.openjdk.org/jdk/compare/d51f4f471f3941294a987dcb68ee264fe27f018a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[edvbld]

Looks good, thanks for fixing!

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit aa43824.
Since your change was applied there have been 66 commits pushed to the master branch:

• b4ab5fe: 8288396: Always create reproducible builds
• 3336971: 8289258: ProblemList some failing custom loader tests with ZGC
• 784fa0a: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions
• ca78f7b: 8286259: Password cleanup after KeyStore.PasswordProtection in P11KeyStore
• e322e77: 8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name
• 40bf3b1: 8288993: Make AwtFramePackTest generic by removing @requires tag
• d4b040f: Merge
• 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
• 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
• 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
• ... and 56 more: https://git.openjdk.org/jdk/compare/d51f4f471f3941294a987dcb68ee264fe27f018a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit aa43824.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.