Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287984: AArch64: [vector] Make all bits set vector sharable for match rules #9292

Closed
wants to merge 1 commit into from

Conversation

XiaohongGong
Copy link

@XiaohongGong XiaohongGong commented Jun 27, 2022

We have the optimized rules for vector not/and_not in NEON and SVE, like:

 match(Set dst (XorV src (ReplicateB m1)))              ; vector not
 match(Set dst (AndV src1 (XorV src2 (ReplicateB m1)))) ; vector and_not

where "m1" is a ConI node with value -1. And we also have the similar rules for vector mask in SVE like:

 match(Set pd (AndVMask pn (XorVMask pm (MaskAll m1)))) ; mask and_not

These rules are not easy to be matched since the "Replicate" or "MaskAll" node is usually not single used for the not/and_not operation. To make these rules be matched as expected, this patch adds the vector (mask) "not" pattern to Matcher::pd_clone_node() which makes the all bits set vector (Replicate/MaskAll) sharable during matching rules.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287984: AArch64: [vector] Make all bits set vector sharable for match rules

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9292/head:pull/9292
$ git checkout pull/9292

Update a local copy of the PR:
$ git checkout pull/9292
$ git pull https://git.openjdk.org/jdk pull/9292/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9292

View PR using the GUI difftool:
$ git pr show -t 9292

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9292.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2022

👋 Welcome back xgong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@XiaohongGong The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2022

Webrevs

@XiaohongGong
Copy link
Author

Hi there, could anyone please take a look at this simple patch? Thanks so much!

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable. Someone familiar with aarch64 code have to review it too.
I will run testing before approval.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My testing passed.

@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@XiaohongGong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8287984: AArch64: [vector] Make all bits set vector sharable for match rules

Reviewed-by: kvn, ngasson

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2022
@XiaohongGong
Copy link
Author

Thanks a lot for your tests and review!

@XiaohongGong
Copy link
Author

@nick-arm @nsjian, may I got the review for your side? Thanks a lot for your time!

Copy link
Contributor

@nick-arm nick-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cpu/aarch64 changes look OK.

@XiaohongGong
Copy link
Author

Thanks for looking at this PR @vnkozlov @nick-arm !

@XiaohongGong
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2022

Going to push as commit 1305fb5.
Since your change was applied there have been 133 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 30, 2022
@openjdk openjdk bot closed this Jun 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2022
@openjdk
Copy link

openjdk bot commented Jun 30, 2022

@XiaohongGong Pushed as commit 1305fb5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XiaohongGong XiaohongGong deleted the JDK-8287984 branch June 30, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants