Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name #9297

Closed

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Jun 27, 2022

A simple test fix for changing the class loader name to a non-literal string so that the symbol refcount could be decremented upon unloading of the class loader.

Passed tiers 1 and 2 testing. Inspected the .jtr file to check the symbol refcount was decremented.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9297/head:pull/9297
$ git checkout pull/9297

Update a local copy of the PR:
$ git checkout pull/9297
$ git pull https://git.openjdk.org/jdk pull/9297/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9297

View PR using the GUI difftool:
$ git pr show -t 9297

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9297.diff

@calvinccheung
Copy link
Member Author

/label add hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2022

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@calvinccheung calvinccheung marked this pull request as ready for review June 27, 2022 17:34
@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@calvinccheung
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 27, 2022

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's subtle but good find.

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288651: CDS test HelloUnload.java should not use literal string as ClassLoader name

Reviewed-by: coleenp, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • d4b040f: Merge
  • 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
  • 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
  • 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
  • 20f55ab: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support
  • bdf9902: 8288120: VerifyError with JEP 405 pattern match
  • b0db333: 8288528: broken links in java.desktop
  • 651cbeb: 8288080: (fc) FileChannel::map for MemorySegments should state it always throws UOE
  • 1f9521e: 8287076: Document.normalizeDocument() produces different results
  • a716f79: 8288589: Files.readString ignores encoding errors for UTF-16
  • ... and 14 more: https://git.openjdk.org/jdk/compare/53b37fe1535388eb14e04c620a6b0118ed8884a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 27, 2022
Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinccheung
Copy link
Member Author

Thanks Coleen, Ioi for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

Going to push as commit e322e77.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2022
@openjdk openjdk bot closed this Jun 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@calvinccheung Pushed as commit e322e77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8288651-HelloUnload branch June 27, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants