-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8289260: BigDecimal movePointLeft() and movePointRight() do not follow their API spec #9307
Conversation
👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into |
@rgiulietti The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
/csr needed |
@rgiulietti , please file a CSR for the behavioral change. |
@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request. @rgiulietti please create a CSR request for issue JDK-8289260 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
CSR is ready as JDK-8289504 |
@rgiulietti This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 93 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@rgiulietti |
/sponsor |
Going to push as commit 35387d5.
Your commit was automatically rebased without conflicts. |
@jddarcy @rgiulietti Pushed as commit 35387d5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
BigDecimal.morePoint[Left|Right]()
should return the targetthis
when the argument is 0 and the scale is non-negative.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9307/head:pull/9307
$ git checkout pull/9307
Update a local copy of the PR:
$ git checkout pull/9307
$ git pull https://git.openjdk.org/jdk pull/9307/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9307
View PR using the GUI difftool:
$ git pr show -t 9307
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9307.diff