Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289260: BigDecimal movePointLeft() and movePointRight() do not follow their API spec #9307

Closed
wants to merge 3 commits into from

Conversation

rgiulietti
Copy link
Contributor

@rgiulietti rgiulietti commented Jun 28, 2022

BigDecimal.morePoint[Left|Right]() should return the target this when the argument is 0 and the scale is non-negative.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8289260: BigDecimal movePointLeft() and movePointRight() do not follow their API spec
  • JDK-8289504: BigDecimal movePointLeft() and movePointRight() do not follow their API spec (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9307/head:pull/9307
$ git checkout pull/9307

Update a local copy of the PR:
$ git checkout pull/9307
$ git pull https://git.openjdk.org/jdk pull/9307/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9307

View PR using the GUI difftool:
$ git pr show -t 9307

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9307.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2022

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2022
@openjdk
Copy link

openjdk bot commented Jun 28, 2022

@rgiulietti The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 28, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2022

Webrevs

@jddarcy
Copy link
Member

jddarcy commented Jun 29, 2022

/csr needed

@jddarcy
Copy link
Member

jddarcy commented Jun 29, 2022

@rgiulietti , please file a CSR for the behavioral change.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jun 29, 2022
@openjdk
Copy link

openjdk bot commented Jun 29, 2022

@jddarcy has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@rgiulietti please create a CSR request for issue JDK-8289260 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@rgiulietti
Copy link
Contributor Author

CSR is ready as JDK-8289504

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jul 5, 2022
@openjdk
Copy link

openjdk bot commented Jul 5, 2022

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289260: BigDecimal movePointLeft() and movePointRight() do not follow their API spec

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

  • d8f4e97: 8289146: containers/docker/TestMemoryWithCgroupV1.java fails on linux ppc64le machine with missing Memory and Swap Limit output
  • f783244: 8289706: (cs) Avoid redundant TreeMap.containsKey call in AbstractCharsetProvider
  • fafe8b3: 8289604: compiler/vectorapi/VectorLogicalOpIdentityTest.java failed on x86 AVX1 system
  • 3515604: 8280481: Duplicated stubs to interpreter for static calls
  • d48694d: 8283335: Add exists and readAttributesIfExists methods to FileSystemProvider
  • c45d613: 8289687: [JVMCI] bug in HotSpotResolvedJavaMethodImpl.equals
  • 77c3bbf: 8289617: Remove test/jdk/java/net/ServerSocket/ThreadStop.java
  • a5934cd: 8289698: AArch64: Need to relativize extended_sp in frame
  • fd1bb07: 8287603: Avoid redundant HashMap.containsKey calls in NimbusDefaults.getDerivedColor
  • 4c997ba: 8289520: G1: Remove duplicate checks in G1BarrierSetC1::post_barrier
  • ... and 83 more: https://git.openjdk.org/jdk/compare/b4ab5fe1daf22a543e1bd973bcd34322360054b4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 5, 2022
@rgiulietti
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 6, 2022
@openjdk
Copy link

openjdk bot commented Jul 6, 2022

@rgiulietti
Your change (at version 9755bb1) is now ready to be sponsored by a Committer.

@jddarcy
Copy link
Member

jddarcy commented Jul 6, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 6, 2022

Going to push as commit 35387d5.
Since your change was applied there have been 103 commits pushed to the master branch:

  • 9f37ba4: 8288706: Unused parameter 'boolean newln' in method java.lang.VersionProps#print(boolean, boolean)
  • dfb24ae: 8289060: Undefined Behaviour in class VMReg
  • 82a8bd7: 8287596: Reorg jdk.test.lib.util.ForceGC
  • cc2b792: 8288992: AArch64: CMN should be handled the same way as CMP
  • 75c0a5b: 8288824: [arm32] Display isetstate in register output
  • 83a5d59: 8278479: RunThese test failure with +UseHeavyMonitors and +VerifyHeavyMonitors
  • cbaf6e8: 8288022: c2: Transform (CastLL (AddL into (AddL (CastLL when possible
  • 8341895: 8289739: Add G1 specific GC breakpoints for testing
  • ac6be16: 8289695: [TESTBUG] TestMemoryAwareness.java fails on cgroups v2 and crun
  • 4ad18cf: 8289730: Deprecated code sample in java.lang.ClassCastException
  • ... and 93 more: https://git.openjdk.org/jdk/compare/b4ab5fe1daf22a543e1bd973bcd34322360054b4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 6, 2022
@openjdk openjdk bot closed this Jul 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 6, 2022
@openjdk
Copy link

openjdk bot commented Jul 6, 2022

@jddarcy @rgiulietti Pushed as commit 35387d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rgiulietti rgiulietti deleted the JDK-8289260 branch September 26, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants